Bug 12206

Summary: Malformed HTML in search result other holdings list
Product: Koha Reporter: paxed <pasi.kallinen>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 12206: fix HTML in other holdings list in staff search results page
Bug 12206: fix HTML in other holdings list in staff search results page
Bug 12206: fix HTML in other holdings list in staff search results page

Description paxed 2014-05-07 05:01:30 UTC
In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:

<ul>
[% FOREACH ALTERNATEHOLDING IN SEARCH_RESULT.ALTERNATEHOLDINGS %]
<li id="alternateholdings">[% ALTERNATEHOLDING.holding %]</li>
[% END %]
</li>

The "</li>" at the end should be "</ul>" instead.
Comment 1 Galen Charlton 2014-05-07 17:46:33 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-05-13 03:48:44 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-05-13 06:58:43 UTC
Created attachment 28195 [details] [review]
Bug 12206: fix HTML in other holdings list in staff search results page

To test:

[1] View, in the staff interface, a record with alternate holdings
    (as controlled by the AlternateHoldingsField system preference).
[2] Verify that the HTML list is closed correctly.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2014-05-13 14:11:21 UTC
Pushed to master.