Summary: | Fix currency symbol for NOK | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Magnus Enger <magnus> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12209 - Fix currency symbol for NOK
[SIGNED-PFF] Bug 12209 - Fix currency symbol for NOK [PASSED QA] Bug 12209 - Fix currency symbol for NOK |
Description
Magnus Enger
2014-05-07 11:41:11 UTC
(In reply to Magnus Enger from comment #0) > The currency symbol for NOK is not $. Probably "kr"? Well, you would know best. How are NOK amounts typically written down? Where is the patch? :) Wikipedia seems to agree with kr: http://en.wikipedia.org/wiki/Norwegian_krone Thanks for caring about the Norwegian kroner, Katrin & Galen! :-) The question mark was mostly as a note to my future self, who will provide a patch, but maybe not today. ;-) Created attachment 28271 [details] [review] Bug 12209 - Fix currency symbol for NOK Dunno why, but the currency symbol for NOK was given as "$", when it should be "kr". To test: - Empty the "currency" table in the DB: DELETE FROM currency; - Load in the file changed by this patch: sudo koha-mysql <instance> < installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql (if you are testing on a (gitified) package install) - Check that "kr" is displayed on /cgi-bin/koha/admin/currency.pl - Add a budget and a fund, and check that "kr" is displayed in the list of funds (currency symbols seem to be missing from the list of budgets) Created attachment 28277 [details] [review] [SIGNED-PFF] Bug 12209 - Fix currency symbol for NOK Dunno why, but the currency symbol for NOK was given as "$", when it should be "kr". To test: - Empty the "currency" table in the DB: DELETE FROM currency; - Load in the file changed by this patch: sudo koha-mysql <instance> < installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql (if you are testing on a (gitified) package install) - Check that "kr" is displayed on /cgi-bin/koha/admin/currency.pl - Add a budget and a fund, and check that "kr" is displayed in the list of funds (currency symbols seem to be missing from the list of budgets) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> file loads ok, kr currency active, no errors Created attachment 28283 [details] [review] [PASSED QA] Bug 12209 - Fix currency symbol for NOK Dunno why, but the currency symbol for NOK was given as "$", when it should be "kr". To test: - Empty the "currency" table in the DB: DELETE FROM currency; - Load in the file changed by this patch: sudo koha-mysql <instance> < installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql (if you are testing on a (gitified) package install) - Check that "kr" is displayed on /cgi-bin/koha/admin/currency.pl - Add a budget and a fund, and check that "kr" is displayed in the list of funds (currency symbols seem to be missing from the list of budgets) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> file loads ok, kr currency active, no errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. Pushed to master. Thanks, Magnus! |