Summary: | Wrong home link in bootstrap opac-auth | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/opac-user.pl | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12211 - Wrong home link in bootstrap opac-auth
Bug 12211 - Wrong home link in bootstrap opac-auth [SIGNED-OFF] Bug 12211 - Wrong home link in bootstrap opac-auth [PASSED QA] Bug 12211 - Wrong home link in bootstrap opac-auth |
Description
Fridolin Somers
2014-05-07 15:58:15 UTC
Created attachment 28030 [details] [review] Bug 12211 - Wrong home link in bootstrap opac-auth In bootstrap opac-auth.tt, the link to "Home" in breadcrumbs leads to #, it should lead to opac-main.pl like in all other pages. Test plan : - Use boostrap opac theme - Go to cgi-bin/koha/opac-user.pl when not logged => without patch, clicking on Home does not change the page => with patch, clicking on Home leads to opac-main.pl This template file is called from Auth.pm, try a fake (opac) login and you will end with this page. Patch is ok, but to really look like the others, it needs to go from this <li><a href="#">Home</a> <span class="divider">›</span></li> <li>Log in</li> to this <li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">›</span></li> <li><a href="#">Log in</a></li> Created attachment 28332 [details] [review] Bug 12211 - Wrong home link in bootstrap opac-auth In bootstrap opac-auth.tt, the link to "Home" in breadcrumbs leads to #, it should lead to opac-main.pl like in all other pages. Test plan : - Use boostrap opac theme - Go to cgi-bin/koha/opac-user.pl when not logged => without patch, clicking on Home does not change the page => with patch, clicking on Home leads to opac-main.pl (In reply to Bernardo Gonzalez Kriegel from comment #2) Here is new patch Comment on attachment 28332 [details] [review] Bug 12211 - Wrong home link in bootstrap opac-auth Review of attachment 28332 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt @@ +14,5 @@ > > <div class="main"> > <ul class="breadcrumb"> > + <li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">›</span></li> > + <li><a href="#">Log in</a></li> Is there a reason you added the href? The title says wrong home link. It says nothing about missing a link on "Log in". Created attachment 28336 [details] [review] [SIGNED-OFF] Bug 12211 - Wrong home link in bootstrap opac-auth In bootstrap opac-auth.tt, the link to "Home" in breadcrumbs leads to #, it should lead to opac-main.pl like in all other pages. Test plan : - Use boostrap opac theme - Go to cgi-bin/koha/opac-user.pl when not logged => without patch, clicking on Home does not change the page => with patch, clicking on Home leads to opac-main.pl Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Link ok, no errors. (In reply to M. Tompsett from comment #5) > Comment on attachment 28332 [details] [review] [review] > > Is there a reason you added the href? The title says wrong home link. It > says nothing about missing a link on "Log in". Just consistency :) Created attachment 28398 [details] [review] [PASSED QA] Bug 12211 - Wrong home link in bootstrap opac-auth In bootstrap opac-auth.tt, the link to "Home" in breadcrumbs leads to #, it should lead to opac-main.pl like in all other pages. Test plan : - Use boostrap opac theme - Go to cgi-bin/koha/opac-user.pl when not logged => without patch, clicking on Home does not change the page => with patch, clicking on Home leads to opac-main.pl Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Link ok, no errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. Pushed to master and 3.16.x. Thanks, Fridolin! Pushed to 3.14.x, will be in 3.14.12. |