| Summary: | The "feed" MTT does not seem to be used | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 12298: The "feed" MTT does not seem to be used and can be removed
Bug 12298: The "feed" MTT does not seem to be used and can be removed [SIGNED OFF] Bug 12298: The "feed" MTT does not seem to be used and can be removed [PASSED QA] Bug 12298: The "feed" MTT does not seem to be used and can be removed [PASSED QA] Bug 12298: The "feed" MTT does not seem to be used and can be removed |
||
|
Description
Jonathan Druart
2014-05-21 07:58:16 UTC
Created attachment 28384 [details] [review] Bug 12298: The "feed" MTT does not seem to be used and can be removed The feed message transport type exists but nobody knows how it can be used. This patch assumes nobody uses it and removes it. Before removing the entry in the DB, the updatedb entry will check if no foreign key exists in order to avoid a delete in cascade. This path does *not* deletes the occurrences in the templates have not been deleted. Test plan: Apply this patch, execute the updatedb script and verify the message_transport_types table does not contain the 'feed' entry if it was not in use. Created attachment 28385 [details] [review] Bug 12298: The "feed" MTT does not seem to be used and can be removed The feed message transport type exists but nobody knows how it can be used. This patch assumes nobody uses it and removes it. Before removing the entry in the DB, the updatedb entry will check if no foreign key exists in order to avoid a delete in cascade. This path does *not* deletes the occurrences in the templates. Test plan: Apply this patch, execute the updatedb script and verify the message_transport_types table does not contain the 'feed' entry if it was not in use. Created attachment 30665 [details] [review] [SIGNED OFF] Bug 12298: The "feed" MTT does not seem to be used and can be removed The feed message transport type exists but nobody knows how it can be used. This patch assumes nobody uses it and removes it. Before removing the entry in the DB, the updatedb entry will check if no foreign key exists in order to avoid a delete in cascade. This path does *not* deletes the occurrences in the templates. Test plan: Apply this patch, execute the updatedb script and verify the message_transport_types table does not contain the 'feed' entry if it was not in use. Signed-off-by: Nick Clemens <nick@debian> Created attachment 30672 [details] [review] [PASSED QA] Bug 12298: The "feed" MTT does not seem to be used and can be removed The feed message transport type exists but nobody knows how it can be used. This patch assumes nobody uses it and removes it. Before removing the entry in the DB, the updatedb entry will check if no foreign key exists in order to avoid a delete in cascade. This path does *not* deletes the occurrences in the templates. Test plan: Apply this patch, execute the updatedb script and verify the message_transport_types table does not contain the 'feed' entry if it was not in use. Signed-off-by: Nick Clemens <nick@nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch will remove the confusing option to configure message texts for feeds. Checked on a database with an existing feed type notice (not deleted) and on one without any references to the feed message transport type (deleted!) Created attachment 30673 [details] [review] [PASSED QA] Bug 12298: The "feed" MTT does not seem to be used and can be removed The feed message transport type exists but nobody knows how it can be used. This patch assumes nobody uses it and removes it. Before removing the entry in the DB, the updatedb entry will check if no foreign key exists in order to avoid a delete in cascade. This path does *not* deletes the occurrences in the templates. Test plan: Apply this patch, execute the updatedb script and verify the message_transport_types table does not contain the 'feed' entry if it was not in use. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch will remove the confusing option to configure message texts for feeds. Checked on a database with an existing feed type notice (not deleted) and on one without any references to the feed message transport type (deleted!) Patch pushed to master. Thanks Jonathan! |