| Summary: | purchase-suggestions.pl tabs do not show selected | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Christopher Brannon <cbrannon> |
| Component: | Circulation | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle.m.hall, sandboxes, tomascohen, viktor.sarge |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12447 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 9261 | ||
| Bug Blocks: | |||
| Attachments: |
12332 Fix for tab "Purchase suggestions" not lighting up
Bug 12332: Fix for tab "Purchase suggestions" not lighting up Bug 12332: Fix for tab "Purchase suggestions" not lighting up |
||
|
Description
Christopher Brannon
2014-05-29 20:00:28 UTC
Created attachment 28865 [details] [review] 12332 Fix for tab "Purchase suggestions" not lighting up This patch changes the file purchase-suggestions.pl with "suggestionsview => 1" for the template parameter. In circ-menu.inc i changed the condition from "suggestions" to "suggestionsview" since it seemed to conflict with the existing variable suggestions (and in that case only highlighting the tab when there were suggestions). Please note that I fixed the troubles with the tab "Fines" in a separate patch 9245. Test plan: 1) Verify that "Purchase suggestions" does not light up as it should when clicked. 2) Install the patch. 3) Verify that the tab "Purchase suggestions" now actually light up when clicked. I tested patch in sandbox 7. It works, but the sandbox won't let me sign off on it. Christopher Sandbox gives me the following message on either patch when I try to sign off on them: It seems you don't have applied a patch, so you cannot sign it off. If you applied patches from the right report, check the commit message of the last patch. It should start with "Bug XXXXX", if not, please inform the author of the patch. I don't know what a commit message is or where to find it. Christopher Created attachment 28920 [details] [review] Bug 12332: Fix for tab "Purchase suggestions" not lighting up This patch changes the file purchase-suggestions.pl with "suggestionsview => 1" for the template parameter. In circ-menu.inc i changed the condition from "suggestions" to "suggestionsview" since it seemed to conflict with the existing variable suggestions (and in that case only highlighting the tab when there were suggestions). Please note that I fixed the troubles with the tab "Fines" in a separate patch 9245. Test plan: 1) Verify that "Purchase suggestions" does not light up as it should when clicked. 2) Install the patch. 3) Verify that the tab "Purchase suggestions" now actually light up when clicked. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Viktor, Please start the commit message of your patches by "Bug XXXXX". Otherwise the sandboxes cannot signoff them. I fixed this one and added the Christopher's signoff. (In reply to Jonathan Druart from comment #5) > Viktor, > Please start the commit message of your patches by "Bug XXXXX". Otherwise > the sandboxes cannot signoff them. > > I fixed this one and added the Christopher's signoff. Thank you for helping out Jonathan and for testing Christopher! I do have things to learn with Git and I'm glad that someone caught that I misformated the commit message before I made more patches. Created attachment 28947 [details] [review] Bug 12332: Fix for tab "Purchase suggestions" not lighting up This patch changes the file purchase-suggestions.pl with "suggestionsview => 1" for the template parameter. In circ-menu.inc i changed the condition from "suggestions" to "suggestionsview" since it seemed to conflict with the existing variable suggestions (and in that case only highlighting the tab when there were suggestions). Please note that I fixed the troubles with the tab "Fines" in a separate patch 9245. Test plan: 1) Verify that "Purchase suggestions" does not light up as it should when clicked. 2) Install the patch. 3) Verify that the tab "Purchase suggestions" now actually light up when clicked. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Patch pushed to master. Thanks Viktor! |