| Summary: | Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message. | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Circulation | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, sandboxes, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message.
Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message. Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message. |
||
|
Description
Kyle M Hall (khall)
2014-05-30 11:17:08 UTC
Created attachment 28568 [details] [review] Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message. Each time the "renew all" or "renew or return" buttons are click, the renewal process is triggered. If the patron only has one renewal left, and the button is multi-clicked, the librarian may receive a "renewal failed" message even though the renewal did occur. In addition, this can just unwanted multiple consecutive renewals as well. Test Plan: 1) Check out an item to a patron that can have 1 renewal 2) Click the "renew all" button multiple times, fast and furiously 3) Note the "renewal failed" messaged 4) Apply this patch 5) Repeat steps 1 and 2 6) Note the item is now renewed without the failure message Patch tested with a sandbox, by Nick Clemens <nick@quecheelibrary.org> Created attachment 28665 [details] [review] Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message. Each time the "renew all" or "renew or return" buttons are click, the renewal process is triggered. If the patron only has one renewal left, and the button is multi-clicked, the librarian may receive a "renewal failed" message even though the renewal did occur. In addition, this can just unwanted multiple consecutive renewals as well. Test Plan: 1) Check out an item to a patron that can have 1 renewal 2) Click the "renew all" button multiple times, fast and furiously 3) Note the "renewal failed" messaged 4) Apply this patch 5) Repeat steps 1 and 2 6) Note the item is now renewed without the failure message Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Created attachment 28709 [details] [review] Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message. Each time the "renew all" or "renew or return" buttons are click, the renewal process is triggered. If the patron only has one renewal left, and the button is multi-clicked, the librarian may receive a "renewal failed" message even though the renewal did occur. In addition, this can just unwanted multiple consecutive renewals as well. Test Plan: 1) Check out an item to a patron that can have 1 renewal 2) Click the "renew all" button multiple times, fast and furiously 3) Note the "renewal failed" messaged 4) Apply this patch 5) Repeat steps 1 and 2 6) Note the item is now renewed without the failure message Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Patch pushed to master. Thanks Kyle! |