Summary: | OverDrive does not depend on SSL modules for LWP, causing searches to fail | ||
---|---|---|---|
Product: | Koha | Reporter: | Jesse Weaver <jweaver> |
Component: | OPAC | Assignee: | Jesse Weaver <jweaver> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12393 - Depend on SSL module for LWP, for OverDrive
Bug 12393 - Depend on SSL module for LWP, for OverDrive [SIGNED-OFF] Bug 12393 - Depend on SSL module for LWP, for OverDrive [PASSED QA] Bug 12393 - Depend on SSL module for LWP, for OverDrive |
Description
Jesse Weaver
2014-06-10 01:13:40 UTC
Misspoke, seems only IO::Socket::SSL is required. Created attachment 28751 [details] [review] Bug 12393 - Depend on SSL module for LWP, for OverDrive The OverDrive integration needs to connect to an authentication server over HTTPS, and many systems do not install the necessary module (LWP::Protocol::https) by default. Test plan (for patch): 1) Run koha_perl_deps.pl -a, verify that LWP::Protocol::https appears in listing. Test plan (to verify that LWP::Protocol::https is necessary, needs OverDrive access): 1) Remove LWP::Protocol::https (liblwp-protocol-https-perl under Debian). 2) Run an OverDrive search on the OPAC, it should fail. 3) Reinstall LWP::Protocol::https. 4) Rerun OverDrive search, it should now succeed. Note: older versions of Debian do not need to install LWP::Protocol::https separately; the Debian scripts have been updated to reflect this divide. Created attachment 28961 [details] [review] Bug 12393 - Depend on SSL module for LWP, for OverDrive The OverDrive integration needs to connect to an authentication server over HTTPS, and many systems do not install the necessary module (LWP::Protocol::https) by default. Test plan (for patch): 1) Run koha_perl_deps.pl -a, verify that LWP::Protocol::https appears in listing. Test plan (to verify that LWP::Protocol::https is necessary, needs OverDrive access): 1) Remove LWP::Protocol::https (liblwp-protocol-https-perl under Debian). 2) Run an OverDrive search on the OPAC, it should fail. 3) Reinstall LWP::Protocol::https. 4) Rerun OverDrive search, it should now succeed. Note: older versions of Debian do not need to install LWP::Protocol::https separately; the Debian scripts have been updated to reflect this divide. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 29055 [details] [review] [SIGNED-OFF] Bug 12393 - Depend on SSL module for LWP, for OverDrive The OverDrive integration needs to connect to an authentication server over HTTPS, and many systems do not install the necessary module (LWP::Protocol::https) by default. Test plan (for patch): 1) Run koha_perl_deps.pl -a, verify that LWP::Protocol::https appears in listing. Test plan (to verify that LWP::Protocol::https is necessary, needs OverDrive access): 1) Remove LWP::Protocol::https (liblwp-protocol-https-perl under Debian). 2) Run an OverDrive search on the OPAC, it should fail. 3) Reinstall LWP::Protocol::https. 4) Rerun OverDrive search, it should now succeed. Note: older versions of Debian do not need to install LWP::Protocol::https separately; the Debian scripts have been updated to reflect this divide. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 29061 [details] [review] [PASSED QA] Bug 12393 - Depend on SSL module for LWP, for OverDrive The OverDrive integration needs to connect to an authentication server over HTTPS, and many systems do not install the necessary module (LWP::Protocol::https) by default. Test plan (for patch): 1) Run koha_perl_deps.pl -a, verify that LWP::Protocol::https appears in listing. Test plan (to verify that LWP::Protocol::https is necessary, needs OverDrive access): 1) Remove LWP::Protocol::https (liblwp-protocol-https-perl under Debian). 2) Run an OverDrive search on the OPAC, it should fail. 3) Reinstall LWP::Protocol::https. 4) Rerun OverDrive search, it should now succeed. Note: older versions of Debian do not need to install LWP::Protocol::https separately; the Debian scripts have been updated to reflect this divide. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Patch pushed to master. Thanks Jesse! Pushed to 3.16.x for inclusion in 3.16.1. |