| 
 
        
          Description
        
        
          Olli-Antti Kivilahti
        
        
        
        
          2014-06-10 06:56:04 UTC
        
       
    Created attachment 28755 [details] [review] solution Created attachment 28757 [details] [review] [SIGNED-OFF] Bug 12396 - MTT FIX: Due notices (DUEDGST) are multiplicated and all of them are sent to everybody who is about to receive ODUEDGST. So the first patron receives correct letters, but the followings received all the previous ones AND his letters. Eventually you end up with !n letters in message_queue where n = amount of patrons receiving due messages as digest and having something due. Eventually we got 4 000 000 ODUEDGST-letters of which 1 100 000 were sent to our patrons :) This is madness! Test plan: 0/ Delete the content of the message_queue table. 1/ Pick 3 patrons and set them to receive due messages as digest. 2/ Check 1 item out for 3 separate patrons and specify a due date today. 3/ Launch the advance_notices.pl script. 4/ Before this patch, you got 6 notices (1+2+3 [!n]). Now, you get 3 notices, 1 for each patron. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Problem exis. Patch work as described following test plan. No koha-qa errors Created attachment 28760 [details] [review] Bug 12396 - MTT FIX: Due notices (DUEDGST) are multiplicated and all of them are sent to everybody who is about to receive ODUEDGST. So the first patron receives correct letters, but the followings received all the previous ones AND his letters. Eventually you end up with !n letters in message_queue where n = amount of patrons receiving due messages as digest and having something due. Eventually we got 4 000 000 ODUEDGST-letters of which 1 100 000 were sent to our patrons :) This is madness! Test plan: 0/ Delete the content of the message_queue table. 1/ Pick 3 patrons and set them to receive due messages as digest. 2/ Check 1 item out for 3 separate patrons and specify a due date today. 3/ Launch the advance_notices.pl script. 4/ Before this patch, you got 6 notices (1+2+3 [!n]). Now, you get 3 notices, 1 for each patron. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Problem exis. Patch work as described following test plan. No koha-qa errors Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This is not blocker but definitely critical. Patch pushed to master. Thanks Olli! Pushed to 3.16.x for inclusion in 3.16.1.  |