| Summary: | Adding a column maxsuspensiondays in the table issuingrules breaks the UT t/db_dependent/Circulation_Issuingrule.t | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Yohann Dufour <yohann.dufour> |
| Component: | Test Suite | Assignee: | Yohann Dufour <yohann.dufour> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | bgkriegel, jonathan.druart, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 12230 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 12406: adding the column maxsuspensiondays in the tests
[SIGNED-OFF] Bug 12406: adding the column maxsuspensiondays in the tests Bug 12406: adding the column maxsuspensiondays in the tests |
||
Created attachment 28784 [details] [review] Bug 12406: adding the column maxsuspensiondays in the tests The column maxsuspensiondays was added in the datatable but not in the tests, which caused the failure of the tests test plan: execute prove t/db_dependent/Circulation_Issuingrule.t The command has to print: t/db_dependent/Circulation_Issuingrule.t .. ok All tests successful. Files=1, Tests=9, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.35 cusr 0.08 csys = 1.47 CPU) Result: PASS Created attachment 28787 [details] [review] [SIGNED-OFF] Bug 12406: adding the column maxsuspensiondays in the tests The column maxsuspensiondays was added in the datatable but not in the tests, which caused the failure of the tests test plan: execute prove t/db_dependent/Circulation_Issuingrule.t The command has to print: t/db_dependent/Circulation_Issuingrule.t .. ok All tests successful. Files=1, Tests=9, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.35 cusr 0.08 csys = 1.47 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Failure on test before patch, success after No koha-qa errors Created attachment 28945 [details] [review] Bug 12406: adding the column maxsuspensiondays in the tests The column maxsuspensiondays was added in the datatable but not in the tests, which caused the failure of the tests test plan: execute prove t/db_dependent/Circulation_Issuingrule.t The command has to print: t/db_dependent/Circulation_Issuingrule.t .. ok All tests successful. Files=1, Tests=9, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.35 cusr 0.08 csys = 1.47 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Failure on test before patch, success after No koha-qa errors Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks Yohann and congratulations for your first patch pushed! Pushed to 3.16.x for inclusion in 3.16.1. I pushed this to 3.16.x in error; it's only needed in master at present. I've reverted this in 3.16.x. |
When we try to execute the UT : prove t/db_dependent/Circulation_issue.t, we got a failure : t/db_dependent/Circulation_Issuingrule.t .. 1/9 # Failed test 'GetIssuingCharge returns issuingrule1's informations' # at t/db_dependent/Circulation_Issuingrule.t line 280. # Structures begin differing at: # $got->{maxsuspensiondays} = undef # $expected->{maxsuspensiondays} = Does not exist # Looks like you failed 1 test of 9. t/db_dependent/Circulation_Issuingrule.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/9 subtests Test Summary Report ------------------- t/db_dependent/Circulation_Issuingrule.t (Wstat: 256 Tests: 9 Failed: 1) Failed test: 3 Non-zero exit status: 1 Files=1, Tests=9, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.43 cusr 0.09 csys = 1.56 CPU) Result: FAIL