Description
Yohann Dufour
2014-06-13 09:18:55 UTC
Created attachment 28834 [details] [review] Bug 12416: add the test of DelUniqueDebarment The subroutine DelUniqueDebarment was not tested test plan: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.46 cusr 0.08 csys = 1.58 CPU) Result: PASS Yohann, Please prefer the use of "is" instead of "ok". Marked as Failed QA. Adding unit tests is far from being 'minor' :) Switch the severity back to normal. Created attachment 28859 [details] [review] Bug 12416: add the test of DelUniqueDebarment The subroutine DelUniqueDebarment was not tested To test: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.43 cusr 0.07 csys = 1.54 CPU) Result: PASS Created attachment 28860 [details] [review] Bug 12416: the subroutine 'ok' is replaced by the subroutine 'is' The use of the subroutine 'is' is prefered over the subroutine 'is' To test: execute the commande prove t/db_dependent/Borrower_Debarments.t To command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.42 cusr 0.08 csys = 1.54 CPU) Result: PASS Created attachment 28861 [details] [review] Bug 12416: add new tests of DelUniqueDebarment The subroutine DelUniqueDebarment was not enough tested To test: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=31, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.44 cusr 0.08 csys = 1.56 CPU) Result: PASS Created attachment 29139 [details] [review] [SIGNED-OFF] Bug 12416: add the test of DelUniqueDebarment The subroutine DelUniqueDebarment was not tested To test: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.43 cusr 0.07 csys = 1.54 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comments on last patch Created attachment 29140 [details] [review] [SIGNED-OFF] Bug 12416: the subroutine 'ok' is replaced by the subroutine 'is' The use of the subroutine 'is' is prefered over the subroutine 'is' To test: execute the commande prove t/db_dependent/Borrower_Debarments.t To command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.42 cusr 0.08 csys = 1.54 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comments on last patch Created attachment 29141 [details] [review] [SIGNED-OFF] Bug 12416: add new tests of DelUniqueDebarment The subroutine DelUniqueDebarment was not enough tested To test: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=31, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.44 cusr 0.08 csys = 1.56 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All 31 test pass, no koha-qa errors Created attachment 29148 [details] [review] [PASSED QA] Bug 12416: add the test of DelUniqueDebarment The subroutine DelUniqueDebarment was not tested To test: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.43 cusr 0.07 csys = 1.54 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comments on last patch Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 29149 [details] [review] [PASSED QA] Bug 12416: the subroutine 'ok' is replaced by the subroutine 'is' The use of the subroutine 'is' is prefered over the subroutine 'is' To test: execute the commande prove t/db_dependent/Borrower_Debarments.t To command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.42 cusr 0.08 csys = 1.54 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comments on last patch Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 29150 [details] [review] [PASSED QA] Bug 12416: add new tests of DelUniqueDebarment The subroutine DelUniqueDebarment was not enough tested To test: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=31, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.44 cusr 0.08 csys = 1.56 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All 31 test pass, no koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass. Patches pushed to master. Thanks Yohann! Pushed to 3.16.x for inclusion in 3.16.1 |