Summary: | Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled when using Bootstrap | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | OPAC | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | cbrannon, mayanksri1989 |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: | Bug 12422 - Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled when using Bootstrap |
Description
Kyle M Hall (khall)
2014-06-13 14:48:15 UTC
Created attachment 28842 [details] [review] Bug 12422 - Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled when using Bootstrap Having the system preference opacbookbag disabled while having virtualshelves enabled will give the following javascript error: Uncaught ReferenceError: MSG_IN_YOUR_CART is not defined basket.js:414 Test plan: 1) Set opactheme to bootstrap 2) Disable opacbookbag, enable virtualshelves 3) Open an OPAC page, view the error console 4) Note the javascript error 5) Apply this patch 6) Reload the page, not the error is gone Is this a duplicate of Bug 11663: fix display of holding tab in Bootstap OPAC when opacbookbag syspref is disabled? (In reply to Owen Leonard from comment #2) > Is this a duplicate of Bug 11663: fix display of holding tab in Bootstap > OPAC when opacbookbag syspref is disabled? I'm not seeing this behavior in master. I'm thinking it may have been addressed in that bug. Kyle, can you confirm if the problem still exists? Christopher I was facing the same problem. Your patch solved it! Thanks! :) (In reply to Kyle M Hall from comment #1) > Created attachment 28842 [details] [review] [review] > Bug 12422 - Javascript error triggered by opacbookbag being disabled while > virtualshelves are enabled when using Bootstrap > > Having the system preference opacbookbag disabled while having > virtualshelves enabled will give the following javascript error: > > Uncaught ReferenceError: MSG_IN_YOUR_CART is not defined basket.js:414 > > Test plan: > 1) Set opactheme to bootstrap > 2) Disable opacbookbag, enable virtualshelves > 3) Open an OPAC page, view the error console > 4) Note the javascript error > 5) Apply this patch > 6) Reload the page, not the error is gone |