| Summary: | Bad encoding in acquisition basket | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Acquisitions | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | dcook, gmcharlt, kyle, paola.rossi, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | cgi-bin/koha/acqui/basket.pl?basketno=x | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 12438 - Bad encoding in acquisition basket
28911: Bug 12438 - Bad encoding in acquisition basket [PASSED QA] Bug 12438 - Bad encoding in acquisition basket |
||
|
Description
Fridolin Somers
2014-06-17 14:38:30 UTC
Created attachment 28911 [details] [review] Bug 12438 - Bad encoding in acquisition basket We noticed a bad encoding (diacritics replaced by <?>) in acquisition basket when updating a server to Debian Wheezy. We found it comes from a query containing biblio.title twice. Maybe the mysql newer version creates this side-effect. Test plan : - Create an order on a record containing a diacritic in title - Look at the basket : cgi-bin/koha/acqui/basket.pl?basketno=x => Without the patch the record title is bad encoded (with <?>) => With this patch the record title is well encoded - Check also basket CSV export It seems to me that this problem is going to be solved by 11944. (In reply to Paola Rossi from comment #2) > It seems to me that this problem is going to be solved by 11944. Maybe, but also the SQL query is wrong. There is no need to add biblio.title when there is biblio.* Thanks, Fridolin I've applied against master 3.17.00.008 Everything's OK. So I've passed tha patch to "Signed Off" status. Created attachment 29209 [details] [review] 28911: Bug 12438 - Bad encoding in acquisition basket Created attachment 29340 [details] [review] [PASSED QA] Bug 12438 - Bad encoding in acquisition basket We noticed a bad encoding (diacritics replaced by <?>) in acquisition basket when updating a server to Debian Wheezy. We found it comes from a query containing biblio.title twice. Maybe the mysql newer version creates this side-effect. Test plan : - Create an order on a record containing a diacritic in title - Look at the basket : cgi-bin/koha/acqui/basket.pl?basketno=x => Without the patch the record title is bad encoded (with <?>) => With this patch the record title is well encoded - Check also basket CSV export Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Good catch! Works as expected, passes tests and QA script. Patch pushed to master. Thanks Fridolin! Note: I pushed it because I think the duplicated biblio.title has to be removed. It hides the real problem, but as bug 11944 actually solves the problem (tried it), I feel good about it making into the stable branches for a short term solution. Beautiful! This patch fixes the problem that I was having! It's worth mentioning that we only had this problem on a Debian Squeeze server. When we dumped the data and loaded it into a Koha instance on an OpenSuse server, we didn't get the <?> replacing the diacritics. It worked perfectly. So...not really sure what was going on there, but I'm just happy at this point to have a fix of the symptom. Pushed to 3.12.x! Pushed to 3.14.x, will be in 3.14.11 Pushed to 3.16.x for inclusion in 3.16.4. |