Summary: | search.pl has incorrect reference to OPACdefaultSortField and OPACdefaultSortOrder | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Searching | Assignee: | Hayley Pelham <hayleypelham> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | hayleypelham, lucas, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00, 18.11.05
|
|
Attachments: |
Bug 12441: Search.pl conditional checks and displays using same syspref
Bug 12441: Search.pl conditional checks and displays using same syspref Bug 12441: Search.pl conditional checks and displays using same syspref |
Description
David Cook
2014-06-18 04:59:49 UTC
This may or may not be fixed... will have to double-check this one of these days... Created attachment 86592 [details] [review] Bug 12441: Search.pl conditional checks and displays using same syspref Script search.pl checks OPACdefaultSortField and OPACdefaultSortOrder, but shows defaultSortField and defaultSortOrder when using Advanced Search in the staff client. Test plan: Apply the patch and then check that the Advanced Search uses defaultSortOrder and defaultSortField sysprefs instead of the OPAC sysprefs in the conditional. Check that sort behaviour in Advanced Search still functions as expected. (It should do - this doesn't change what displays, just improves consistency). Sponsored-by: Catalyst IT Created attachment 87239 [details] [review] Bug 12441: Search.pl conditional checks and displays using same syspref Script search.pl checks OPACdefaultSortField and OPACdefaultSortOrder, but shows defaultSortField and defaultSortOrder when using Advanced Search in the staff client. Test plan: Apply the patch and then check that the Advanced Search uses defaultSortOrder and defaultSortField sysprefs instead of the OPAC sysprefs in the conditional. Check that sort behaviour in Advanced Search still functions as expected. (It should do - this doesn't change what displays, just improves consistency). Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23@gmail.com> Created attachment 87245 [details] [review] Bug 12441: Search.pl conditional checks and displays using same syspref Script search.pl checks OPACdefaultSortField and OPACdefaultSortOrder, but shows defaultSortField and defaultSortOrder when using Advanced Search in the staff client. Test plan: Apply the patch and then check that the Advanced Search uses defaultSortOrder and defaultSortField sysprefs instead of the OPAC sysprefs in the conditional. Check that sort behaviour in Advanced Search still functions as expected. (It should do - this doesn't change what displays, just improves consistency). Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Good catch! Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 backported to 18.05.x for 18.05.12 |