Bug 12453

Summary:	Do not use by default Host-Item-Number in UNIMARC
Product:	Koha	Reporter:	Fridolin Somers <fridolin.somers>
Component:	Installation and upgrade (command-line installer)	Assignee:	Fridolin Somers <fridolin.somers>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	jonathan.druart, mathsabypro, tomascohen
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 12453 - Do not use by default Host-Item-Number in UNIMARC Bug 12453 - Do not use by default Host-Item-Number in UNIMARC [PASSED QA] Bug 12453 - Do not use by default Host-Item-Number in UNIMARC

Description Fridolin Somers 2014-06-19 14:00:32 UTC

Actually, in default UNIMARC install, 461$9 is indexed as Host-Item-Number, meaning it is used for analytical itemnumber.

But most UNIMARC catalog use the analytical relation using unimarc_field_4XX.pl plugin on 461$a. In fact, this plugin is defined in default UNIMARC frameworks.

If Host-Item-Number is defined but 461$9 is used for something else, it will lead to odd bugs. For example, records containing analytical items can not be deleted.

I propose the comment the 461$9 indexing in UNIMARC zebra config.

Comment 1 Fridolin Somers 2014-06-19 14:15:04 UTC Comment hidden (obsolete)

Created attachment 29040 [details] [review]
Bug 12453 - Do not use by default Host-Item-Number in UNIMARC

Actually, in default UNIMARC install, 461$9 is indexed as Host-Item-Number, meaning it is used for analytical itemnumber.

But most UNIMARC catalog use the analytical relation using unimarc_field_4XX.pl plugin on 461$a. In fact, this plugin is defined in default UNIMARC frameworks.

If Host-Item-Number is defined but 461$9 is used for something else, it will lead to odd bugs. For example, records containing analytical items can not be deleted.

This patch comments the 461$9 indexing in UNIMARC zebra config.

Test plan :
- Create a fresh UNIMARC install
- Create a record with 461$9 containing a value
- Index the record
- Perform a search on Host-Item-Number : ccl=Host-Item-Number,alwaysmatches=''
=> Without the patch you get a result
=> With the patch you get no result

Comment 2 Chris Cormack 2014-07-29 06:55:14 UTC Comment hidden (obsolete)

Created attachment 30261 [details] [review]
Bug 12453 - Do not use by default Host-Item-Number in UNIMARC

Actually, in default UNIMARC install, 461$9 is indexed as Host-Item-Number, meaning it is used for analytical itemnumber.

But most UNIMARC catalog use the analytical relation using unimarc_field_4XX.pl plugin on 461$a. In fact, this plugin is defined in default UNIMARC frameworks.

If Host-Item-Number is defined but 461$9 is used for something else, it will lead to odd bugs. For example, records containing analytical items can not be deleted.

This patch comments the 461$9 indexing in UNIMARC zebra config.

Test plan :
- Create a fresh UNIMARC install
- Create a record with 461$9 containing a value
- Index the record
- Perform a search on Host-Item-Number : ccl=Host-Item-Number,alwaysmatches=''
=> Without the patch you get a result
=> With the patch you get no result

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Comment 3 Katrin Fischer 2014-08-17 10:26:28 UTC

Created attachment 30896 [details] [review]
[PASSED QA] Bug 12453 - Do not use by default Host-Item-Number in UNIMARC

Actually, in default UNIMARC install, 461$9 is indexed as Host-Item-Number, meaning it is used for analytical itemnumber.

But most UNIMARC catalog use the analytical relation using unimarc_field_4XX.pl plugin on 461$a. In fact, this plugin is defined in default UNIMARC frameworks.

If Host-Item-Number is defined but 461$9 is used for something else, it will lead to odd bugs. For example, records containing analytical items can not be deleted.

This patch comments the 461$9 indexing in UNIMARC zebra config.

Test plan :
- Create a fresh UNIMARC install
- Create a record with 461$9 containing a value
- Index the record
- Perform a search on Host-Item-Number : ccl=Host-Item-Number,alwaysmatches=''
=> Without the patch you get a result
=> With the patch you get no result

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Code is clean, commenting out all the indexing of 461$9.
Trusting the author that this is the correct thing to do :)

Comment 4 Tomás Cohen Arazi (tcohen) 2014-08-24 16:33:09 UTC

Patch pushed to master.

Thanks Fridolin!

Comment 5 Mathieu Saby 2014-08-25 06:17:57 UTC

Hi Fridolin
I never really understood analytic records ;-)
Do you mean unimarc users should not follow this section of the manual?
http://manual.koha-community.org/3.16/en/cataloging.html#catalogenhanceanalytics

Mathieu

Comment 6 Fridolin Somers 2014-09-03 16:03:05 UTC

(In reply to mathieu saby from comment #5)
> Hi Fridolin
> I never really understood analytic records ;-)
> Do you mean unimarc users should not follow this section of the manual?
> http://manual.koha-community.org/3.16/en/cataloging.
> html#catalogenhanceanalytics
> 
> Mathieu

Indeed. This manal speaks about field 773 so MARC21.
Have a look at UNIMARC default framework, it defines analytics on biblio records with 461 and 463. This is not compatible with easy analytics (on items).