Bug 12454

Summary: Can't add new patron categories
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: System AdministrationAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: critical    
Priority: P5 - low CC: gmcharlt, jonathan.druart, tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
Bug Depends on: 6254    
Bug Blocks:    
Attachments: Bug 12454: Fix for adding new patron categories
[SIGNED-OFF] Bug 12454: Can't add new patron categories
Bug 12454: Can't add new patron categories

Description Katrin Fischer 2014-06-19 15:38:50 UTC
It's not possible to add a new patron category. There is a DB error in the logs but no feedback in staff, the newly created category just doesn't show up.
Comment 1 Katrin Fischer 2014-06-19 15:47:59 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-06-19 16:23:17 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-06-20 10:45:59 UTC
Created attachment 29090 [details] [review]
Bug 12454: Can't add new patron categories

To test:
- Add a new patron category
- After saving, the new patron category won't show up in the list
- Apply patch
- Try to add a new patron category again
- It should now save correctly and show up in the list of patron
  categories.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Jonathan Druart 2014-06-20 10:48:55 UTC
Bug introduced by bug 6254.
Comment 5 Tomás Cohen Arazi 2014-06-21 00:17:42 UTC
Patch pushed to master.

Thanks Katrina!

Note: I'd like to see all this business logic be put in a lib in the Koha namespace we can have unit tests written for it. I'm sure this would belong to another bug report anyway.