| Summary: | The module C4/SMS.pm needs more unit tests | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Yohann Dufour <yohann.dufour> |
| Component: | Test Suite | Assignee: | Yohann Dufour <yohann.dufour> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | bgkriegel, tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 12455: adding unit tests for the module C4/SMS.pm
[SIGNED-OFF] Bug 12455: adding unit tests for the module C4/SMS.pm [PASSED QA] Bug 12455: adding unit tests for the module C4/SMS.pm Bug 12455: (QA followup) license text missing |
||
|
Description
Yohann Dufour
2014-06-20 07:24:06 UTC
Created attachment 29086 [details] [review] Bug 12455: adding unit tests for the module C4/SMS.pm The module C4/SMS.pm was not tested Test plan: 1/ Execute the command : prove t/SMS.t 2/ The result has to be a success without error or warning : t/SMS.t .. ok All tests successful. Files=1, Tests=7, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.17 cusr 0.02 csys = 0.23 CPU) Result: PASS Created attachment 29155 [details] [review] [SIGNED-OFF] Bug 12455: adding unit tests for the module C4/SMS.pm The module C4/SMS.pm was not tested Test plan: 1/ Execute the command : prove t/SMS.t 2/ The result has to be a success without error or warning : t/SMS.t .. ok All tests successful. Files=1, Tests=7, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.17 cusr 0.02 csys = 0.23 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Replace stub test, all test pass. Removed "use strict/warnings", no need for that with "use Modern::Perl" No koha-qa errors Created attachment 29184 [details] [review] [PASSED QA] Bug 12455: adding unit tests for the module C4/SMS.pm The module C4/SMS.pm was not tested Test plan: 1/ Execute the command : prove t/SMS.t 2/ The result has to be a success without error or warning : t/SMS.t .. ok All tests successful. Files=1, Tests=7, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.17 cusr 0.02 csys = 0.23 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Replace stub test, all test pass. Removed "use strict/warnings", no need for that with "use Modern::Perl" No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 29379 [details] [review] Bug 12455: (QA followup) license text missing Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Patch pushed to master. Thanks Yohann! Pushed to 3.16.x for inclusion in 3.16.2. |