Summary: | Street number missing from hold alert on checkin page | ||
---|---|---|---|
Product: | Koha | Reporter: | David Roberts <david.roberts> |
Component: | Circulation | Assignee: | David Roberts <david.roberts> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, kyle, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Proposed patch
[SIGNED-OFF] Bug 12495 - Include streetnumber in hold alert address [PASSED QA] Bug 12495 - Include streetnumber in hold alert address Bug 12495 [QA Followup] - Re-work "Renew or return" button as well Bug 12495 [QA Followup] - Re-work "Renew or return" button as well Bug 12495 [QA Followup] - Re-word "Renew or return" button as well |
Description
David Roberts
2014-06-27 22:52:27 UTC
Created attachment 29378 [details] [review] Proposed patch Please don't forget to assign bugs to yourself if you are supplying a patch. If the patch is ready for testing the status of the bug should be changed to "needs signoff." A patch which is ready for testing should include a test plan in the commit message. To test this, place a hold on an item that is on-loan, having first made sure that the requesting user has a value in the street number field of his address. Check the item in, and an alert should appear giving the name and address of the requesting user. This address should include the contents of the street number address field. (In reply to Owen Leonard from comment #2) > Please don't forget to assign bugs to yourself if you are supplying a patch. > If the patch is ready for testing the status of the bug should be changed to > "needs signoff." A patch which is ready for testing should include a test > plan in the commit message. Sorry - I'm new to this! :-) Hope everything is OK now. Created attachment 29380 [details] [review] [SIGNED-OFF] Bug 12495 - Include streetnumber in hold alert address Steetnumber is not included in the addess in the hold alert add the field to those displayed To test this, place a hold on an item that is on-loan, having first made sure that the requesting user has a value in the street number field of his address. Check the item in, and an alert should appear giving the name and address of the requesting user. This address should include the contents of the street number address field. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I was able to confirm three of the four template changes for the following cases: - Item placed on hold for a patron at the current library, not waiting - Item placed on hold for a patron at the current library, already waiting - Item placed on hold for a patron at another library, not waiting I don't know how to trigger the case [% IF ( diffbranch ) %]. Created attachment 29526 [details] [review] [PASSED QA] Bug 12495 - Include streetnumber in hold alert address Steetnumber is not included in the addess in the hold alert add the field to those displayed To test this, place a hold on an item that is on-loan, having first made sure that the requesting user has a value in the street number field of his address. Check the item in, and an alert should appear giving the name and address of the requesting user. This address should include the contents of the street number address field. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I was able to confirm three of the four template changes for the following cases: - Item placed on hold for a patron at the current library, not waiting - Item placed on hold for a patron at the current library, already waiting - Item placed on hold for a patron at another library, not waiting I don't know how to trigger the case [% IF ( diffbranch ) %]. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Note: Maybe sample slip templates should also include street number? Hi David, I believe this is your first patch - thanks and congratulations :) Patch pushed to master. Thanks, and congratulations David! Note: a discussion on how to compose addresses with different naming schemas (a.k.a. 'localized') is in place, but belongs to another bug. Created attachment 34902 [details] [review] Bug 12495 [QA Followup] - Re-work "Renew or return" button as well Created attachment 34903 [details] [review] Bug 12495 [QA Followup] - Re-work "Renew or return" button as well Created attachment 34904 [details] [review] Bug 12495 [QA Followup] - Re-word "Renew or return" button as well |