Summary: | Novelist Select not using https in bootstrap | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | OPAC | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | crohde, gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12511 - Novelist Select not using https in bootstrap
[PASSED QA] Bug 12511 - Novelist Select not using https in bootstrap |
Description
Kyle M Hall (khall)
2014-07-01 15:28:30 UTC
Created attachment 29410 [details] [review] Bug 12511 - Novelist Select not using https in bootstrap In prog we have: [% IF ( NovelistSelectProfile ) %] <script type="text/javascript" src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> [% END %] but in bootstrap we have [% IF ( NovelistSelectProfile ) %] <script type="text/javascript" src="http://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> [% END %] Because bootstrap isn't using https, we get an error like this: [blocked] The page at 'https://koha.mylibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=105315&query_desc=kw%2Cwrdl%3A%20home' was loaded over HTTPS, but ran insecure content from 'http://imageserver.ebscohost.com/novelistselect/ns2init.js': this content should also be loaded over HTTPS. Test plan would require having a subscription to Novelist Select. I think this is trivial enough to go without. We have NoveList Select, are running Bootstrap, on an https server. The patch works on our server. Created attachment 29528 [details] [review] [PASSED QA] Bug 12511 - Novelist Select not using https in bootstrap In prog we have: [% IF ( NovelistSelectProfile ) %] <script type="text/javascript" src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> [% END %] but in bootstrap we have [% IF ( NovelistSelectProfile ) %] <script type="text/javascript" src="http://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> [% END %] Because bootstrap isn't using https, we get an error like this: [blocked] The page at 'https://koha.mylibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=105315&query_desc=kw%2Cwrdl%3A%20home' was loaded over HTTPS, but ran insecure content from 'http://imageserver.ebscohost.com/novelistselect/ns2init.js': this content should also be loaded over HTTPS. Test plan would require having a subscription to Novelist Select. I think this is trivial enough to go without. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Very small change, trusting Kyle and the sign-off here. Patch pushed to master. Thanks Kyle! Pushed to 3.16.x for inclusion in 3.16.2. |