| Summary: | Download and send list popups broken in bootstrap OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | bgkriegel, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 12517 - Download and send list popups broken in bootstrap OPAC
[SIGNED-OFF] Bug 12517 - Download and send list popups broken in bootstrap OPAC [PASSED QA] Bug 12517 - Download and send list popups broken in bootstrap OPAC |
||
|
Description
Owen Leonard
2014-07-02 13:09:22 UTC
Created attachment 29437 [details] [review] Bug 12517 - Download and send list popups broken in bootstrap OPAC A JavaScript error prevents the download list and send list links in the bootstrap OPAC from functioning correctly. A variable declaration was removed from basket.js during the creation of the theme but opac-shelves.tt was not changed accordingly. This patch corrects it. To test, view an existing shelf in the bootstrap OPAC and test the "download list" and "send list" links. They should each trigger popups without any errors. Created attachment 29443 [details] [review] [SIGNED-OFF] Bug 12517 - Download and send list popups broken in bootstrap OPAC A JavaScript error prevents the download list and send list links in the bootstrap OPAC from functioning correctly. A variable declaration was removed from basket.js during the creation of the theme but opac-shelves.tt was not changed accordingly. This patch corrects it. To test, view an existing shelf in the bootstrap OPAC and test the "download list" and "send list" links. They should each trigger popups without any errors. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Popups pops again, no koha-qa errors Created attachment 29481 [details] [review] [PASSED QA] Bug 12517 - Download and send list popups broken in bootstrap OPAC A JavaScript error prevents the download list and send list links in the bootstrap OPAC from functioning correctly. A variable declaration was removed from basket.js during the creation of the theme but opac-shelves.tt was not changed accordingly. This patch corrects it. To test, view an existing shelf in the bootstrap OPAC and test the "download list" and "send list" links. They should each trigger popups without any errors. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Popups pops again, no koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Owen! |