Bug 12521

Summary: Arrangement of divs on opac-advsearch.tt
Product: Koha Reporter: Liz Rea <liz>
Component: OPACAssignee: Liz Rea <liz>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: abl, mathsabypro, oleonard, tomascohen, veron
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 12697    
Attachments: Bug 12521 - Change layout a bit of the opac advanced search
[Signed-off] Bug 12521 - Change layout a bit of the opac advanced search
[PASSED QA] Bug 12521 - Change layout a bit of the opac advanced search

Description Liz Rea 2014-07-02 22:09:11 UTC
Was having a talk with one of our designers here, she had a concern about the div-happiness of the advanced search page. I had a look, and tend to agree with her - without so many container-fluids, and putting everything in the main div, the page is easier to style.

The extra container-fluid divs seem superfluous - they don't have extra classes on them for targeting with CSS. The page is broken up in a rather strange way - while talking with her I realised that I had simply gotten used to the way it looks, and hadn't given it any thought at all that it could be different or better.

The attached patch I have run past her, and she finds it more pleasing to style than the old structure. The patch doesn't change any functionality - only layout.


I'd especially like to hear from Owen on this, please. :)

Liz
Comment 1 Liz Rea 2014-07-02 22:10:37 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-07-26 16:52:57 UTC Comment hidden (obsolete)
Comment 3 Mathieu Saby 2014-07-26 17:57:39 UTC
Hello
Has anybody ran a UX survey on this page? I have always thought this page was rather unfriendly for average users, but no real proof of that.

Mathieu Saby
Comment 4 Liz Rea 2014-07-27 21:19:39 UTC
Not that I am aware of. Generally, a UX survey of the OPAC would be a good thing to do.

Liz
Comment 5 Katrin Fischer 2014-08-15 10:02:32 UTC
Created attachment 30823 [details] [review]
[PASSED QA] Bug 12521 - Change layout a bit of the opac advanced search

To test:

Load up the advanced search and make sure it displays properly, with all of the elements within the main div, and only one container-fluid.

Patch behaves as expected. Advanced search looks much better now.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked visually and with HTML validator.
Comment 6 Tomás Cohen Arazi (tcohen) 2014-09-18 01:00:30 UTC
Patch pushed to master.

Thanks Liz!