Summary: | PROG/CCSR Deprecation: Make opac translation theme independent | ||
---|---|---|---|
Product: | Koha | Reporter: | Bernardo Gonzalez Kriegel <bgkriegel> |
Component: | I18N/L10N | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, f.demians, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 11346 | ||
Attachments: |
Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent
Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent [PASSED QA] Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent |
Description
Bernardo Gonzalez Kriegel
2014-07-07 03:37:32 UTC
Created attachment 29534 [details] [review] Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent This patch makes opac translation files theme independent A side effect is that current prog translation file is renamed. But the renaming is not added, that gives a patch of ~60M! Current list of languages are now obtained from pref files. To test: 1) Apply the patch 2) For your preferred language, rename opac prog file from 'xx-YY-i-opac-t-prog-v-3006000.po' to 'xx-YY-opac-prog.po' 3) Update that language, there must be no errors cd misc/translation ./translate update xx-YY [-v] Check updated po files 4) Install any language, there must be no errors ./translate install xx-YY Check prog theme for that language 5) Create translation files. Remove a language or create new lang files ./translate create zz-WW ls -l po/zz-WW*po check there are 3 files (and *~) for opac 6) Check updated pod for LangInstaler.pm and translate script When PROG/CCSR themes are removed, I'll add a Bug to remove corresponding files. Perhaps RM could add a followup to rename all files, cd misc/translator/po for old in $(ls *opac-t*); do new=$(echo $old | sed 's/-i-opac-t-prog-v-3006000/-opac-prog/'); git mv $old $new; done Created attachment 30084 [details] [review] Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent This patch makes opac translation files theme independent A side effect is that current prog translation file is renamed. But the renaming is not added, that gives a patch of ~60M! Current list of languages are now obtained from pref files. To test: 1) Apply the patch 2) For your preferred language, rename opac prog file from 'xx-YY-i-opac-t-prog-v-3006000.po' to 'xx-YY-opac-prog.po' 3) Update that language, there must be no errors cd misc/translation ./translate update xx-YY [-v] Check updated po files 4) Install any language, there must be no errors ./translate install xx-YY Check prog theme for that language 5) Create translation files. Remove a language or create new lang files ./translate create zz-WW ls -l po/zz-WW*po check there are 3 files (and *~) for opac 6) Check updated pod for LangInstaler.pm and translate script When PROG/CCSR themes are removed, I'll add a Bug to remove corresponding files. Perhaps RM could add a followup to rename all files, cd misc/translator/po for old in $(ls *opac-t*); do new=$(echo $old | sed 's/-i-opac-t-prog-v-3006000/-opac-prog/'); git mv $old $new; done Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 30517 [details] [review] [PASSED QA] Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent This patch makes opac translation files theme independent A side effect is that current prog translation file is renamed. But the renaming is not added, that gives a patch of ~60M! Current list of languages are now obtained from pref files. To test: 1) Apply the patch 2) For your preferred language, rename opac prog file from 'xx-YY-i-opac-t-prog-v-3006000.po' to 'xx-YY-opac-prog.po' 3) Update that language, there must be no errors cd misc/translation ./translate update xx-YY [-v] Check updated po files 4) Install any language, there must be no errors ./translate install xx-YY Check prog theme for that language 5) Create translation files. Remove a language or create new lang files ./translate create zz-WW ls -l po/zz-WW*po check there are 3 files (and *~) for opac 6) Check updated pod for LangInstaler.pm and translate script When PROG/CCSR themes are removed, I'll add a Bug to remove corresponding files. Perhaps RM could add a followup to rename all files, cd misc/translator/po for old in $(ls *opac-t*); do new=$(echo $old | sed 's/-i-opac-t-prog-v-3006000/-opac-prog/'); git mv $old $new; done Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. Pushed to MM-OPAC/theme_dep Patch merged into master. Thanks Bernardo! |