Summary: | Wrong message if all cover images deleted | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Templates | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | sandboxes |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12559: Wrong message if all cover images deleted
Bug 12559: Wrong message if all cover images deleted [PASSED QA] Bug 12559: Wrong message if all cover images deleted |
Description
Tomás Cohen Arazi (tcohen)
2014-07-11 18:33:42 UTC
Created attachment 29654 [details] [review] Bug 12559: Wrong message if all cover images deleted If a record contains a (one or more) local cover image and it is deleted, a wrong message is presented in the UI. To reproduce: - Have LocalCoverImages set to "Display" and AllowMultipleCovers set to "Allow". - Go to the detail page of a record that has no images attached. - The 'Images' tab conveniently shows the following message: "No images have been uploaded..." - Use the "upload" link to add a local cover to the record - Complete the process, and "view final record". - The 'Images' tab shows the added cover. - Delete the cover image using the link below the cover. => FAIL: 'Click on an image...' message still shows instead of 'No images have been...' To test: - Apply the patch - Repeat the previous steps => SUCCESS : 'No images have been...' Bonus points: previous code didn't show a message at all if the user didn't have permissions to upload local cover images. I've split the message in two: - 'No images have been...' (for everyone) - 'Please upload (link)...' (for those with the right permissions :-D Regards To+ Edit: I used JavaScript to inject the 'No images...' message to aid localization. It can be improved once we fix some stuff in the translation scripts to better support placeholders/variables in the templates. Sponsored-by: Universidad Nacional de Cordoba Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com> Created attachment 29689 [details] [review] Bug 12559: Wrong message if all cover images deleted If a record contains a (one or more) local cover image and it is deleted, a wrong message is presented in the UI. To reproduce: - Have LocalCoverImages set to "Display" and AllowMultipleCovers set to "Allow". - Go to the detail page of a record that has no images attached. - The 'Images' tab conveniently shows the following message: "No images have been uploaded..." - Use the "upload" link to add a local cover to the record - Complete the process, and "view final record". - The 'Images' tab shows the added cover. - Delete the cover image using the link below the cover. => FAIL: 'Click on an image...' message still shows instead of 'No images have been...' To test: - Apply the patch - Repeat the previous steps => SUCCESS : 'No images have been...' Bonus points: previous code didn't show a message at all if the user didn't have permissions to upload local cover images. I've split the message in two: - 'No images have been...' (for everyone) - 'Please upload (link)...' (for those with the right permissions :-D Regards To+ Edit: I used JavaScript to inject the 'No images...' message to aid localization. It can be improved once we fix some stuff in the translation scripts to better support placeholders/variables in the templates. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Created attachment 29829 [details] [review] [PASSED QA] Bug 12559: Wrong message if all cover images deleted If a record contains a (one or more) local cover image and it is deleted, a wrong message is presented in the UI. To reproduce: - Have LocalCoverImages set to "Display" and AllowMultipleCovers set to "Allow". - Go to the detail page of a record that has no images attached. - The 'Images' tab conveniently shows the following message: "No images have been uploaded..." - Use the "upload" link to add a local cover to the record - Complete the process, and "view final record". - The 'Images' tab shows the added cover. - Delete the cover image using the link below the cover. => FAIL: 'Click on an image...' message still shows instead of 'No images have been...' To test: - Apply the patch - Repeat the previous steps => SUCCESS : 'No images have been...' Bonus points: previous code didn't show a message at all if the user didn't have permissions to upload local cover images. I've split the message in two: - 'No images have been...' (for everyone) - 'Please upload (link)...' (for those with the right permissions :-D Regards To+ Edit: I used JavaScript to inject the 'No images...' message to aid localization. It can be improved once we fix some stuff in the translation scripts to better support placeholders/variables in the templates. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. |