| Summary: | Control of branch displayed in search results linked to HomeOrHoldingBranch | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Searching | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gwilliams, jrobb, melissa, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch
Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch [PASSED QA] Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch |
||
|
Description
Kyle M Hall (khall)
2014-07-16 11:08:39 UTC
Created attachment 29743 [details] [review] Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch Some libraries would like the ability choose to display the home branch on search results while having circulation rules based on the holding branch. This is currently impossible because both the display of the branch in search results, and the selection of the home or holding branch for circulation rules are controlled by the same system preference: HomeOrHoldingBranch. This preference is described as being used only for circulation rules, and makes no mention of its use for display control. The display control should be split off into a separate preference. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note the value of the new system preference StaffSearchResultsDisplayBranch matches the current value of HomeOrHoldingBranch 4) Set the preference to home branch 5) Perform a staff catalog search with results having items with differing home and holding branches. 6) Note the home branch displays 7) Set the preference to holding branch 8) Repeat step 5 9) Note the holding branch displays Created attachment 29744 [details] [review] Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch Some libraries would like the ability choose to display the home branch on search results while having circulation rules based on the holding branch. This is currently impossible because both the display of the branch in search results, and the selection of the home or holding branch for circulation rules are controlled by the same system preference: HomeOrHoldingBranch. This preference is described as being used only for circulation rules, and makes no mention of its use for display control. The display control should be split off into a separate preference. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note the value of the new system preference StaffSearchResultsDisplayBranch matches the current value of HomeOrHoldingBranch 4) Set the preference to home branch 5) Perform a staff catalog search with results having items with differing home and holding branches. 6) Note the home branch displays 7) Set the preference to holding branch 8) Repeat step 5 9) Note the holding branch displays I've tested this and it works as described. Created attachment 29844 [details] [review] Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch Created attachment 30957 [details] [review] [PASSED QA] Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch Some libraries would like the ability choose to display the home branch on search results while having circulation rules based on the holding branch. This is currently impossible because both the display of the branch in search results, and the selection of the home or holding branch for circulation rules are controlled by the same system preference: HomeOrHoldingBranch. This preference is described as being used only for circulation rules, and makes no mention of its use for display control. The display control should be split off into a separate preference. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note the value of the new system preference StaffSearchResultsDisplayBranch matches the current value of HomeOrHoldingBranch 4) Set the preference to home branch 5) Perform a staff catalog search with results having items with differing home and holding branches. 6) Note the home branch displays 7) Set the preference to holding branch 8) Repeat step 5 9) Note the holding branch displays Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, logic is now tied to a new system preference. Passes tests and QA script. I wonder if there is a way we could avoid another preference for this, but it works as described. Patch pushed to master. Thanks Kyle! |