Summary: | Duplicated use statement in Search.pm | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | Searching | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
[SIGNED-OFF] Bug 12600: remove duplicate use statement from code [PASSED QA] Bug 12600: remove duplicate use statement from code |
Description
Colin Campbell
2014-07-18 08:49:58 UTC
Created attachment 29811 [details] [review] Proposed patch Test: search,pm still compiles after patch amended to flag this as a trivial patch Created attachment 30153 [details] [review] [SIGNED-OFF] Bug 12600: remove duplicate use statement from code A use C4::Charset was added deep in the body of the code we have already imported it at the top of the file (the by convention normal place) As use is executed at compile time specifying it in the code body does not serve a useful purpose and detracts from the readability of an already overly complex subroutine. Remove the superfluous statement also removed the tabs introduced to the surrounding lines by the same commit Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Search still works, no errors. Created attachment 30161 [details] [review] [PASSED QA] Bug 12600: remove duplicate use statement from code A use C4::Charset was added deep in the body of the code we have already imported it at the top of the file (the by convention normal place) As use is executed at compile time specifying it in the code body does not serve a useful purpose and detracts from the readability of an already overly complex subroutine. Remove the superfluous statement also removed the tabs introduced to the surrounding lines by the same commit Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Search still works, no errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch pushed to master. Thanks Colin! Pushed to 3.16.x for inclusion in 3.16.4. |