| Summary: | Replace use of DBI in C4::Tags with DBIx::Class | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Architecture, internals, and plumbing | Assignee: | Galen Charlton <gmcharlt> |
| Status: | CLOSED WONTFIX | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 12608 | ||
| Attachments: |
Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class
Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class |
||
|
Description
Kyle M Hall (khall)
2014-07-18 16:38:00 UTC
Created attachment 29860 [details] [review] Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Tags.t 3) Note all unit tests pass Created attachment 29861 [details] [review] Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Tags.t 3) Note all unit tests pass Created attachment 29862 [details] [review] Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Tags.t 3) Note all unit tests pass Created attachment 29863 [details] [review] Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Tags.t 3) Note all unit tests pass (In reply to Kyle M Hall from comment #4) > 3) Note all unit tests pass It would have work if t/db_dependent/Tags.t covered all subroutines from C4::Tags. It is not the case at all, only stratify_tags is covered. Would it be possible to add some unit tests to this file to prove all your changes don't introduce regression? I don't have time to continue working on this patch. |