Summary: | Remove CGI::scrolling_list from marc_subfields_structure.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Bernardo Gonzalez Kriegel <bgkriegel> |
Component: | Templates | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl
Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl [PASSED QA] Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl |
Description
Bernardo Gonzalez Kriegel
2014-07-20 13:31:54 UTC
Created attachment 29897 [details] [review] Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl This patch removes all instances on this file. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 020 5. Clic 'Edit subfields' button Now the tests proper 6. On any subfield, check pulldown 'Managed in tab', was replaced, so test if it works and search for regressions Change, save, load, change again 7. Clic on 'Other options' box Eight(8) scrolling_list removed, they use to feed the four pulldowns, so check each one 'Koha field' is new (for me at last) 'Authorised value', 'Thesaurus' (is this valid/useful here?) 'Plugin' Check assign/remove/save/load values, search for regressions Check adding a new subfield (In reply to Bernardo Gonzalez Kriegel from comment #1) > 'Koha field' is new (for me at last) Actually it should be in the "Advanced constraints" tab. With your patch, I get the "Koha field" in the last tab "Other options (choose one)" but I get "Koha link:HASH(0xc9b9ca8)" in the "Advanced constraints". Marked as Failed QA. Created attachment 30131 [details] [review] Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl This patch removes all instances on this file. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 020 5. Clic 'Edit subfields' button Now the tests proper 6. On any subfield, check pulldown 'Managed in tab', was replaced, so test if it works and search for regressions Change, save, load, change again 7. Clic on 'Advanced constraints' (2) scrolling list removed At the bottom, check 'Koha link', was changed Check assign/remove/save/load values, search for regressions 8. Clic on 'Other options' box Eight(6) scrolling_list removed, they use to feed three pulldowns, so check each one 'Authorised value', 'Thesaurus' 'Plugin' Check assign/remove/save/load values, search for regressions Check adding a new subfield (In reply to Jonathan Druart from comment #2) > > Actually it should be in the "Advanced constraints" tab. > With your patch, I get the "Koha field" in the last tab "Other options > (choose one)" but I get "Koha link:HASH(0xc9b9ca8)" in the "Advanced > constraints". > > Marked as Failed QA. Oops, FQA is absolutely correct! Fixed now :) Created attachment 30260 [details] [review] Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl This patch removes all instances on this file. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 020 5. Clic 'Edit subfields' button Now the tests proper 6. On any subfield, check pulldown 'Managed in tab', was replaced, so test if it works and search for regressions Change, save, load, change again 7. Clic on 'Advanced constraints' (2) scrolling list removed At the bottom, check 'Koha link', was changed Check assign/remove/save/load values, search for regressions 8. Clic on 'Other options' box Eight(6) scrolling_list removed, they use to feed three pulldowns, so check each one 'Authorised value', 'Thesaurus' 'Plugin' Check assign/remove/save/load values, search for regressions Check adding a new subfield Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 30315 [details] [review] [PASSED QA] Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl This patch removes all instances on this file. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 020 5. Clic 'Edit subfields' button Now the tests proper 6. On any subfield, check pulldown 'Managed in tab', was replaced, so test if it works and search for regressions Change, save, load, change again 7. Clic on 'Advanced constraints' (2) scrolling list removed At the bottom, check 'Koha link', was changed Check assign/remove/save/load values, search for regressions 8. Clic on 'Other options' box Eight(6) scrolling_list removed, they use to feed three pulldowns, so check each one 'Authorised value', 'Thesaurus' 'Plugin' Check assign/remove/save/load values, search for regressions Check adding a new subfield Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script, no regressions found. Patch pushed to master. Thanks Bernardo! |