Summary: | SMS.t requires a database | ||
---|---|---|---|
Product: | Koha | Reporter: | Robin Sheat <robin> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | major | ||
Priority: | P5 - low | CC: | jonathan.druart, mtj, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 12657 | ||
Attachments: |
Bug 12642 - move SMS.t to the db_dependant directory
Bug 12642: t/SMS.t should not be db dependent Bug 12642: t/SMS.t should not be db dependent [PASSED QA] Bug 12642: t/SMS.t should not be db dependent Bug 12642 - combined changelog updates for 3.16 |
Description
Robin Sheat
2014-07-24 01:08:07 UTC
Created attachment 30010 [details] [review] Bug 12642 - move SMS.t to the db_dependant directory This needs to happen for both master and 3.16. Created attachment 30076 [details] [review] Bug 12642: t/SMS.t should not be db dependent SMS.t should not dependent on the DB. Test plan: verify that prove t/SMS.t returns green even if the DB is not there. Hi Robin, I proposed a counter patch, could you please have a look? Created attachment 30177 [details] [review] Bug 12642: t/SMS.t should not be db dependent SMS.t should not dependent on the DB. Test plan: verify that prove t/SMS.t returns green even if the DB is not there. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Looks good to me, and a better solution than mine. Created attachment 30179 [details] [review] [PASSED QA] Bug 12642: t/SMS.t should not be db dependent SMS.t should not dependent on the DB. Test plan: verify that prove t/SMS.t returns green even if the DB is not there. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Turned off MySQL, tests still pass. Patch pushed to master. Thanks Jonathan! Created attachment 33969 [details] [review] Bug 12642 - combined changelog updates for 3.16 Comment on attachment 33969 [details] [review] Bug 12642 - combined changelog updates for 3.16 That was not the right bug number. Pushed to 3.16.x, patch will be in 3.16.8 |