Description
Jacek Ablewicz
2014-07-25 08:55:15 UTC
Created attachment 30077 [details] [review] Bug 12662 - Ajax-based check in does not work for some system preference settings enabled To reproduce: - enable "InProcessingToShelvingCart" or "ReturnToShelvingCart" system preference, - for a sample patron with 1+ checkouts, try to check in some item[s] using checkboxes in the "Check in" column in the checkouts table which is displayed in the "Check out" or "Details" patron account tabs, - observe that clicking "Renew or return checked items" button only results in ajax "spinning wheel" stuck in infinite loop; check-in operation is not performed. To test: - follow the steps above to reproduce this bug - apply patch - redo the test; ensure that this issue is no longer reproductible. Created attachment 30079 [details] [review] Bug 12662 - Ajax-based check in does not work for some system preference settings enabled To reproduce: - enable "InProcessingToShelvingCart" or "ReturnToShelvingCart" system preference, - for a sample patron with 1+ checkouts, try to check in some item[s] using checkboxes in the "Check in" column in the checkouts table which is displayed in the "Check out" or "Details" patron account tabs, - observe that clicking "Renew or return checked items" button only results in ajax "spinning wheel" stuck in infinite loop; check-in operation is not performed. To test: - follow the steps above to reproduce this bug - apply patch - redo the test; ensure that this issue is no longer reproductible. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 30080 [details] [review] Bug 12662: (follow-up) Ajax-based check in does not work for some system preference settings enabled ModItem is needed too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Before your patch, I got [Fri Jul 25 12:41:22 2014] checkin: Undefined subroutine &main::GetItem called at /home/koha/src/svc/checkin line 58. And after: [Fri Jul 25 12:42:09 2014] checkin: Undefined subroutine &main::ModItem called at /home/koha/src/svc/checkin line 68. :) But after yours and mine, only warnings... Created attachment 30105 [details] [review] [PASSED QA] Bug 12662 - Ajax-based check in does not work for some system preference settings enabled To reproduce: - enable "InProcessingToShelvingCart" or "ReturnToShelvingCart" system preference, - for a sample patron with 1+ checkouts, try to check in some item[s] using checkboxes in the "Check in" column in the checkouts table which is displayed in the "Check out" or "Details" patron account tabs, - observe that clicking "Renew or return checked items" button only results in ajax "spinning wheel" stuck in infinite loop; check-in operation is not performed. To test: - follow the steps above to reproduce this bug - apply patch - redo the test; ensure that this issue is no longer reproductible. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 30106 [details] [review] [PASSED QA] Bug 12662: (follow-up) Ajax-based check in does not work for some system preference settings enabled ModItem is needed too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patches pushed to master. Thanks Jacek" Pushed to 3.16.x for inclusion in 3.16.3. |