Bug 12662

Summary: Ajax-based check in does not work for some system preference settings enabled
Product: Koha Reporter: Jacek Ablewicz <abl>
Component: CirculationAssignee: Jacek Ablewicz <abl>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, jonathan.druart, kyle.m.hall, kyle, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 12662 - Ajax-based check in does not work for some system preference settings enabled
Bug 12662 - Ajax-based check in does not work for some system preference settings enabled
Bug 12662: (follow-up) Ajax-based check in does not work for some system preference settings enabled
[PASSED QA] Bug 12662 - Ajax-based check in does not work for some system preference settings enabled
[PASSED QA] Bug 12662: (follow-up) Ajax-based check in does not work for some system preference settings enabled

Description Jacek Ablewicz 2014-07-25 08:55:15 UTC
To reproduce:

- enable "InProcessingToShelvingCart" or "ReturnToShelvingCart" system preference,
- for a sample patron with 1+ checkouts, try to check in some item[s] using checkboxes in the "Check in" column in the checkouts table which is displayed in the "Check out" or "Details" patron account tabs,
- observe that clicking "Renew or return checked items" button only results in ajax "spinning wheel" stuck in infinite loop; check-in operation is not performed.
Comment 1 Jacek Ablewicz 2014-07-25 09:06:21 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-07-25 10:43:57 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-07-25 10:44:01 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-07-25 10:44:51 UTC
Before your patch, I got
[Fri Jul 25 12:41:22 2014] checkin: Undefined subroutine &main::GetItem called at /home/koha/src/svc/checkin line 58.

And after:
[Fri Jul 25 12:42:09 2014] checkin: Undefined subroutine &main::ModItem called at /home/koha/src/svc/checkin line 68.


:)

But after yours and mine, only warnings...
Comment 5 Kyle M Hall (khall) 2014-07-25 13:42:36 UTC
Created attachment 30105 [details] [review]
[PASSED QA] Bug 12662 - Ajax-based check in does not work for some system preference settings enabled

To reproduce:

- enable "InProcessingToShelvingCart" or "ReturnToShelvingCart"
system preference,
- for a sample patron with 1+ checkouts, try to check in some item[s]
using checkboxes in the "Check in" column in the checkouts table
which is displayed in the "Check out" or "Details" patron account tabs,
- observe that clicking "Renew or return checked items" button only
results in ajax "spinning wheel" stuck in infinite loop; check-in
operation is not performed.

To test:

- follow the steps above to reproduce this bug
- apply patch
- redo the test; ensure that this issue is no longer reproductible.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall (khall) 2014-07-25 13:42:46 UTC
Created attachment 30106 [details] [review]
[PASSED QA] Bug 12662: (follow-up) Ajax-based check in does not work for some system preference settings enabled

ModItem is needed too.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi (tcohen) 2014-07-30 17:52:31 UTC
Patches pushed to master.

Thanks Jacek"
Comment 8 Galen Charlton 2014-08-26 22:45:39 UTC
Pushed to 3.16.x for inclusion in 3.16.3.