| Summary: | Offline Circulation has poor HTML | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
| Component: | Circulation | Assignee: | Mark Tompsett <mtompset> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 12666 - Fix poor HTML from circ/offline.tt
[SIGNED-OFF] Bug 12666 - Fix poor HTML from circ/offline.tt [PASSED QA] Bug 12666 - Fix poor HTML from circ/offline.tt |
||
|
Description
Mark Tompsett
2014-07-28 21:40:17 UTC
Created attachment 30238 [details] [review] Bug 12666 - Fix poor HTML from circ/offline.tt In koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt - Cleaned up the HTML's missing </div>'s - Corrected the autobuffer attribute to the newer preload one - Added into empty title, since it will get replaced TEST PLAN --------- 1) Run the circ/offline.pl page source through an HTML validator -- should get a few warnings 2) Apply patch 3) Recheck page source (confirm your page isn't cached!) -- should be clean Created attachment 30465 [details] [review] [SIGNED-OFF] Bug 12666 - Fix poor HTML from circ/offline.tt In koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt - Cleaned up the HTML's missing </div>'s - Corrected the autobuffer attribute to the newer preload one - Added into empty title, since it will get replaced TEST PLAN --------- 1) Run the circ/offline.pl page source through an HTML validator -- should get a few warnings 2) Apply patch 3) Recheck page source (confirm your page isn't cached!) -- should be clean Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 30495 [details] [review] [PASSED QA] Bug 12666 - Fix poor HTML from circ/offline.tt In koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt - Cleaned up the HTML's missing </div>'s - Corrected the autobuffer attribute to the newer preload one - Added into empty title, since it will get replaced TEST PLAN --------- 1) Run the circ/offline.pl page source through an HTML validator -- should get a few warnings 2) Apply patch 3) Recheck page source (confirm your page isn't cached!) -- should be clean Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Improves HTML validity, no regressions found. Patch pushed to master. Thanks Mark! |