| Summary: | Use Bootstrap "label" style for inline OPAC renewal messages | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 12568 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages
[Signed-off] Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages [PASSED QA] Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages |
||
|
Description
Owen Leonard
2014-07-30 15:38:50 UTC
Created attachment 30472 [details] [review] Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages This patch revises the styling of the renewal success message to use a default Bootstrap style more suited to inline messages. I think this is preferable to using the alert style because the alert is designed to be a block-level element. http://getbootstrap.com/2.3.2/components.html#labels-badges Because Koha's CSS already uses a "label" class for something else I duplicate the Bootstrap "label" class in opac.css as "blabel." The Bootstrap color definitions are included. To test, follow the test plan already provided: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table Created attachment 30482 [details] [review] [Signed-off] Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages This patch revises the styling of the renewal success message to use a default Bootstrap style more suited to inline messages. I think this is preferable to using the alert style because the alert is designed to be a block-level element. http://getbootstrap.com/2.3.2/components.html#labels-badges Because Koha's CSS already uses a "label" class for something else I duplicate the Bootstrap "label" class in opac.css as "blabel." The Bootstrap color definitions are included. To test, follow the test plan already provided: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 30491 [details] [review] [PASSED QA] Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages This patch revises the styling of the renewal success message to use a default Bootstrap style more suited to inline messages. I think this is preferable to using the alert style because the alert is designed to be a block-level element. http://getbootstrap.com/2.3.2/components.html#labels-badges Because Koha's CSS already uses a "label" class for something else I duplicate the Bootstrap "label" class in opac.css as "blabel." The Bootstrap color definitions are included. To test, follow the test plan already provided: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. Patch pushed to master. Thanks Owen! |