|
Description
simith.doliveira
2014-07-31 15:05:09 UTC
Created attachment 30415 [details] [review] Bug 12683 - Use NoLoginInstructions to customize text for OPAC user/pass information Enable staff to setting a text for OPAC user/pass information Modified: C4/Auth.pm koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -add a text to the popup login page koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-main.tt -add a text to the main login page Testing: I Apply the patch 0) Search NoLoginInstructions preference 1) Add/modify a text 2) Open OPAC main page 3) Validate the text added under Login button 4) Click in "Log in to your account" link 5) Validate the text added under input password (popup) Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Created attachment 30447 [details] [review] [Signed-off] Bug 12683 - Use NoLoginInstructions to customize text for OPAC user/pass information Enable staff to setting a text for OPAC user/pass information Modified: C4/Auth.pm koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -add a text to the popup login page koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-main.tt -add a text to the main login page Testing: I Apply the patch 0) Search NoLoginInstructions preference 1) Add/modify a text 2) Open OPAC main page 3) Validate the text added under Login button 4) Click in "Log in to your account" link 5) Validate the text added under input password (popup) Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> QA Comment: In case you click on Log in to your account in the top bar, a login popup appears. In that case the NoLoginInstructions are next to the password and not below the password as suggested. This is just a small design thing, but it does not look good. Failed QA Created attachment 30736 [details] [review] Popup correction patch. Created attachment 30739 [details] [review] [Signed-off] Popup correction patch. Button in pop-up displays now as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 30750 [details] [review] Bug 12683 - Use NoLoginInstructions to customize text for OPAC user/pass information Enable staff to setting a text for OPAC user/pass information Modified: C4/Auth.pm koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -add a text to the popup login page koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-main.tt -add a text to the main login page Testing: I Apply the patch 0) Search NoLoginInstructions preference 1) Add/modify a text 2) Open OPAC main page 3) Validate the text added under Login button 4) Click in "Log in to your account" link 5) Validate the text added under input password (popup) Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Patch behaves as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 30751 [details] [review] Bug 12683: Follow-up, adding div tags around NoLoginInstructions Button in pop-up displays now as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 30839 [details] [review] Bug 12683: (followup) use the Koha.Preference plugin and add ids It is kosher now to use the Koha template toolkit plugin for retrieving system preferences values. This followup does that. It also changes the class for ids, for people considering this patch introduces too much noise on the home screen being able to control its visibility. Regards To+ Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Patches pushed to master. Thanks Simith! (In reply to Tomás Cohen Arazi from comment #8) > Created attachment 30839 [details] [review] [review] > Bug 12683: (followup) use the Koha.Preference plugin and add ids > > It is kosher now to use the Koha template toolkit plugin for retrieving > system preferences values. This followup does that. I agree it's kinda kosher that way ;) but the problem is, for a current master such a change seems to introduce rather nasty side effects regarding UFT-8 characters encoding in great many OPAC pages; see bug 12411 for details. |