Summary: | opacuserjs gets loaded twice in self checkout | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Self checkout | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12690 - opacuserjs gets loaded twice in self checkout
[Signed-off] Bug 12690 - opacuserjs gets loaded twice in self checkout [PASSED QA] Bug 12690 - opacuserjs gets loaded twice in self checkout |
Description
David Cook
2014-08-01 06:30:13 UTC
Created attachment 30441 [details] [review] Bug 12690 - opacuserjs gets loaded twice in self checkout This patch removes a second instance of "opacuserjs" in the opac self-checkout. _TEST PLAN_ 1) Enable OPAC Self-checkout in the system preferences 2) Type the following code into your "opacuserjs" system preference: alert("This is a test"); 2) Visit /cgi-bin/koha/sco/sco-main.pl 3) Note that you get a pop-up saying "This is a test" twice. 4) Apply the patch 5) Refresh /cgi-bin/koha/sco/sco-main.pl 6) Note that you now only get a pop-up saying "This is a test" once. Created attachment 30444 [details] [review] [Signed-off] Bug 12690 - opacuserjs gets loaded twice in self checkout This patch removes a second instance of "opacuserjs" in the opac self-checkout. _TEST PLAN_ 1) Enable OPAC Self-checkout in the system preferences 2) Type the following code into your "opacuserjs" system preference: alert("This is a test"); 2) Visit /cgi-bin/koha/sco/sco-main.pl 3) Note that you get a pop-up saying "This is a test" twice. 4) Apply the patch 5) Refresh /cgi-bin/koha/sco/sco-main.pl 6) Note that you now only get a pop-up saying "This is a test" once. Followed test plan, patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 30501 [details] [review] [PASSED QA] Bug 12690 - opacuserjs gets loaded twice in self checkout This patch removes a second instance of "opacuserjs" in the opac self-checkout. _TEST PLAN_ 1) Enable OPAC Self-checkout in the system preferences 2) Type the following code into your "opacuserjs" system preference: alert("This is a test"); 2) Visit /cgi-bin/koha/sco/sco-main.pl 3) Note that you get a pop-up saying "This is a test" twice. 4) Apply the patch 5) Refresh /cgi-bin/koha/sco/sco-main.pl 6) Note that you now only get a pop-up saying "This is a test" once. Followed test plan, patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> opac-bottom.inc already adds opacuserjs, so the additional line in this template can be removed. Works as described, no problems found. Patch pushed to master. Thanks David! |