Summary: | Surplus closing </div> in OPAC advanced search (bootstrap) | ||
---|---|---|---|
Product: | Koha | Reporter: | Jacek Ablewicz <abl> |
Component: | OPAC | Assignee: | Jacek Ablewicz <abl> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | abl, bgkriegel, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 12521 | ||
Bug Blocks: | |||
Attachments: |
Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap)
[SIGNED-OFF] Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap) [PASSED QA] Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap) |
Description
Jacek Ablewicz
2014-08-02 08:12:47 UTC
Created attachment 30486 [details] [review] Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap) In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template, there is a surplus closing </div> in line 336 (= line 332, in case Bug 12521 is applied first): 336: </div> <!-- / .span4 --> which causes some minor layout problems for this page - i.e.: page footer ("Powered by Koha" + custom footer set up in system prefrences - if any) is "glued" to the bottom (to the language selection bar); unless Bug 12521 is applied first, this affects the placement of the 2nd search bar as well. To reproduce: 1/ go to the OPAC advanced search page 2/ zoom out (e.g., use Ctrl-<minus> several times) and obeserve the result 3/ no need for step 2/ (zooming out) when using a display with (relatively) high vertical resolution; also, this particullar problem gets more apparent/more noticeable with MARC21/USMASRC "subtype" options being hidden in the OPAC advanced search (Bug 9043). To test: 1/ ensure that Bug 12521 is applied first/already applied 2/ apply patch 3/ confirm that this issue is no longer reroductible Created attachment 30597 [details] [review] [SIGNED-OFF] Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap) In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template, there is a surplus closing </div> in line 336 (= line 332, in case Bug 12521 is applied first): 336: </div> <!-- / .span4 --> which causes some minor layout problems for this page - i.e.: page footer ("Powered by Koha" + custom footer set up in system prefrences - if any) is "glued" to the bottom (to the language selection bar); unless Bug 12521 is applied first, this affects the placement of the 2nd search bar as well. To reproduce: 1/ go to the OPAC advanced search page 2/ zoom out (e.g., use Ctrl-<minus> several times) and obeserve the result 3/ no need for step 2/ (zooming out) when using a display with (relatively) high vertical resolution; also, this particullar problem gets more apparent/more noticeable with MARC21/USMASRC "subtype" options being hidden in the OPAC advanced search (Bug 9043). To test: 1/ ensure that Bug 12521 is applied first/already applied 2/ apply patch 3/ confirm that this issue is no longer reroductible Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of 12521, don't know exactly what to reproduce, but surplus '</div>' is real (33 open, 34 close). Everything looks correct, no koha-qa errors. Created attachment 30824 [details] [review] [PASSED QA] Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap) In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template, there is a surplus closing </div> in line 336 (= line 332, in case Bug 12521 is applied first): 336: </div> <!-- / .span4 --> which causes some minor layout problems for this page - i.e.: page footer ("Powered by Koha" + custom footer set up in system prefrences - if any) is "glued" to the bottom (to the language selection bar); unless Bug 12521 is applied first, this affects the placement of the 2nd search bar as well. To reproduce: 1/ go to the OPAC advanced search page 2/ zoom out (e.g., use Ctrl-<minus> several times) and obeserve the result 3/ no need for step 2/ (zooming out) when using a display with (relatively) high vertical resolution; also, this particullar problem gets more apparent/more noticeable with MARC21/USMASRC "subtype" options being hidden in the OPAC advanced search (Bug 9043). To test: 1/ ensure that Bug 12521 is applied first/already applied 2/ apply patch 3/ confirm that this issue is no longer reroductible Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of 12521, don't know exactly what to reproduce, but surplus '</div>' is real (33 open, 34 close). Everything looks correct, no koha-qa errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch pushed to master. Thanks Jacek! |