Summary: | OPAC privacy page still accessible when the feature is turned off | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | mirko, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/opac-privacy.pl | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12703 - OPAC privacy page still accessible when the feature is turned off
Bug 12703 - OPAC privacy page still accessible when the feature is turned off [PASSED QA] Bug 12703 - OPAC privacy page still accessible when the feature is turned off |
Description
Katrin Fischer
2014-08-02 22:02:44 UTC
Created attachment 33655 [details] [review] Bug 12703 - OPAC privacy page still accessible when the feature is turned off If the OPACPrivacy system preference is turned off it is still possible to navigate directly to the OPAC privacy page if you know the URL. This patch adapts the fix for Bug 10595 (OpacTopissue page still accessible when system preference is turned off) for opac-privacy.pl Because the OPACPrivacy preference is irrelevant if opacreadinghistory is not turned on, the patch adds a check for both to determine whether the page should be accessible. Log in to the OPAC and test under the following conditions: - OPACPrivacy is turned off, opacreadinghistory is turned off. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned off, opacreadinghistory is turned on. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned on, opacreadinghistory is turned off. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned on, opacreadinghistory is turned on. A link to both "your reading history" and "your privacy" should appear in the left-hand sidebar menu. Both pages should work. Created attachment 33686 [details] [review] Bug 12703 - OPAC privacy page still accessible when the feature is turned off If the OPACPrivacy system preference is turned off it is still possible to navigate directly to the OPAC privacy page if you know the URL. This patch adapts the fix for Bug 10595 (OpacTopissue page still accessible when system preference is turned off) for opac-privacy.pl Because the OPACPrivacy preference is irrelevant if opacreadinghistory is not turned on, the patch adds a check for both to determine whether the page should be accessible. Log in to the OPAC and test under the following conditions: - OPACPrivacy is turned off, opacreadinghistory is turned off. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned off, opacreadinghistory is turned on. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned on, opacreadinghistory is turned off. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned on, opacreadinghistory is turned on. A link to both "your reading history" and "your privacy" should appear in the left-hand sidebar menu. Both pages should work. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Created attachment 33700 [details] [review] [PASSED QA] Bug 12703 - OPAC privacy page still accessible when the feature is turned off If the OPACPrivacy system preference is turned off it is still possible to navigate directly to the OPAC privacy page if you know the URL. This patch adapts the fix for Bug 10595 (OpacTopissue page still accessible when system preference is turned off) for opac-privacy.pl Because the OPACPrivacy preference is irrelevant if opacreadinghistory is not turned on, the patch adds a check for both to determine whether the page should be accessible. Log in to the OPAC and test under the following conditions: - OPACPrivacy is turned off, opacreadinghistory is turned off. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned off, opacreadinghistory is turned on. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned on, opacreadinghistory is turned off. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned on, opacreadinghistory is turned on. A link to both "your reading history" and "your privacy" should appear in the left-hand sidebar menu. Both pages should work. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and qa script. Patch pushed to master. Thanks Owen! |