| Summary: | Turn off Authority logging when running "bulkmarcimport.pl" | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Command-line Utilities | Assignee: | David Cook <dcook> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | bgkriegel, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 12720 - Turn off Authority logging when running "bulkmarcimport.pl"
[SIGNED-OFF] Bug 12720 - Turn off Authority logging when running "bulkmarcimport.pl" [PASSED QA] Bug 12720 - Turn off Authority logging when running "bulkmarcimport.pl" Bug 12720: (QA followup) use API instead of plain SQL |
||
|
Description
David Cook
2014-08-05 07:03:20 UTC
Created attachment 30550 [details] [review] Bug 12720 - Turn off Authority logging when running "bulkmarcimport.pl" This patch turns off the AuthoritiesLogging syspref when running the bulkmarcimport.pl script. It also temporarily disables the syspref caching which will have been making the CataloguingLogging handling ineffectual. (That is, updating the CataloguingLogging syspref in the script wouldn't have an effect as the original cached value would be used anyway.) _TEST PLAN_ 0) Turn on "AuthoritiesLogging" syspref 1) Load an authority record using bulkmarcimport.pl 2) Note a new Authorities entry in action_logs 3) Apply the patch 4) Repeat Step 1 5) Note that no new entry is made in action_logs (Bonus points: Do the same thing with CataloguingLogging and a bibliographic record.) Created attachment 30560 [details] [review] [SIGNED-OFF] Bug 12720 - Turn off Authority logging when running "bulkmarcimport.pl" This patch turns off the AuthoritiesLogging syspref when running the bulkmarcimport.pl script. It also temporarily disables the syspref caching which will have been making the CataloguingLogging handling ineffectual. (That is, updating the CataloguingLogging syspref in the script wouldn't have an effect as the original cached value would be used anyway.) _TEST PLAN_ 0) Turn on "AuthoritiesLogging" syspref 1) Load an authority record using bulkmarcimport.pl 2) Note a new Authorities entry in action_logs 3) Apply the patch 4) Repeat Step 1 5) Note that no new entry is made in action_logs (Bonus points: Do the same thing with CataloguingLogging and a bibliographic record.) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with biblio and auth imports. Work as described, no koha-qa errors. Note: If you begin to load a big file and get impatient and hit ^C, seems that current syspref value is lost... Created attachment 30956 [details] [review] [PASSED QA] Bug 12720 - Turn off Authority logging when running "bulkmarcimport.pl" This patch turns off the AuthoritiesLogging syspref when running the bulkmarcimport.pl script. It also temporarily disables the syspref caching which will have been making the CataloguingLogging handling ineffectual. (That is, updating the CataloguingLogging syspref in the script wouldn't have an effect as the original cached value would be used anyway.) _TEST PLAN_ 0) Turn on "AuthoritiesLogging" syspref 1) Load an authority record using bulkmarcimport.pl 2) Note a new Authorities entry in action_logs 3) Apply the patch 4) Repeat Step 1 5) Note that no new entry is made in action_logs (Bonus points: Do the same thing with CataloguingLogging and a bibliographic record.) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with biblio and auth imports. Work as described, no koha-qa errors. Note: If you begin to load a big file and get impatient and hit ^C, seems that current syspref value is lost... Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. Patch copies what was already done for the CatalougingLog, no problems found. Created attachment 31127 [details] [review] Bug 12720: (QA followup) use API instead of plain SQL Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Patch pushed to master. Thanks David! |