Summary: | Patron category filter in batch patron deletion tool is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Jacek Ablewicz <abl> |
Component: | Tools | Assignee: | Jacek Ablewicz <abl> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P3 | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12727 - Patron category filter in batch patron deletion tool is broken
Bug 12727 - Patron category filter in batch patron deletion tool is broken [PASSED QA] Bug 12727 - Patron category filter in batch patron deletion tool is broken |
Description
Jacek Ablewicz
2014-08-07 08:26:06 UTC
Created attachment 30568 [details] [review] Bug 12727 - Patron category filter in batch patron deletion tool is broken After commit 6973e3b7d50777a147a29f2f3d213a6175c9eb74, patron category filter in batch patron deletion tool (tools/cleanborrowers.pl) doesn't work properly any longer. It's still possible to choose a patron category as selection criterion, but this criterion is being efectivelly ignored on futhers steps. As a result, all patrons (with no check-outs and no outstanding account balance) may get mistakenly deleted when using this tool, despite their respective categories. To test: 1/ apply patch 2/ follow the test plan[s] for Bug 11975 Created attachment 30608 [details] [review] Bug 12727 - Patron category filter in batch patron deletion tool is broken After commit 6973e3b7d50777a147a29f2f3d213a6175c9eb74, patron category filter in batch patron deletion tool (tools/cleanborrowers.pl) doesn't work properly any longer. It's still possible to choose a patron category as selection criterion, but this criterion is being efectivelly ignored on futhers steps. As a result, all patrons (with no check-outs and no outstanding account balance) may get mistakenly deleted when using this tool, despite their respective categories. To test: 1/ apply patch 2/ follow the test plan[s] for Bug 11975 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 30670 [details] [review] [PASSED QA] Bug 12727 - Patron category filter in batch patron deletion tool is broken After commit 6973e3b7d50777a147a29f2f3d213a6175c9eb74, patron category filter in batch patron deletion tool (tools/cleanborrowers.pl) doesn't work properly any longer. It's still possible to choose a patron category as selection criterion, but this criterion is being efectivelly ignored on futhers steps. As a result, all patrons (with no check-outs and no outstanding account balance) may get mistakenly deleted when using this tool, despite their respective categories. To test: 1/ apply patch 2/ follow the test plan[s] for Bug 11975 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. Patch pushed to master. Thanks Jacek! |