Summary: | Set library in staff client should have 'Cancel' link | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Staff interface | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 12744 - Set language in staff client should have 'Cancel' link
Bug 12744 - Set language in staff client should have 'Cancel' link Bug 12744 - Set language in staff client should have 'Cancel' link [SIGNED-OFF] Bug 12744 - Set language in staff client should have 'Cancel' link [PASSED QA] Bug 12744 - Set language in staff client should have 'Cancel' link |
Description
Marc Véron
2014-08-11 14:13:46 UTC
Created attachment 30691 [details] [review] Bug 12744 - Set language in staff client should have 'Cancel' link Test plan Without patch: Click on Library name in head of any staff client page anc choose 'Set library' Result: Form 'Set library' with no 'Cancel' near 'Submit' button With patch: Form displays 'Cancel' link. This link closes the form and takes you back to the page where you came from. This works great for me, but I have one minor issue: The "Cancel" link should not have an empty "onclick" attribute. I followed a pattern from an other place with 'Cancel' Would the following be better? <a class="cancel" id="cancel_set_library" href="[% referer or '/cgi-bin/koha/circ/circulation.pl' %]">Cancel</a> (In reply to Marc Véron from comment #3) > Would the following be better? > > <a class="cancel" id="cancel_set_library" href="[% referer or > '/cgi-bin/koha/circ/circulation.pl' %]">Cancel</a> Yes. If you found instances where there is an empty onclick attribute the onclick should be removed. Created attachment 30704 [details] [review] Bug 12744 - Set language in staff client should have 'Cancel' link Test plan Without patch: Click on Library name in head of any staff client page anc choose 'Set library' Result: Form 'Set library' with no 'Cancel' near 'Submit' button With patch: Form displays 'Cancel' link. This link closes the form and takes you back to the page where you came from. New patch without empty "onclick" attribute. Mistaked with git add. New patch follows. Created attachment 30707 [details] [review] Bug 12744 - Set language in staff client should have 'Cancel' link Test plan Without patch: Click on Library name in head of any staff client page anc choose 'Set library' Result: Form 'Set library' with no 'Cancel' near 'Submit' button With patch: Form displays 'Cancel' link. This link closes the form and takes you back to the page where you came from. New patch without empty "onclick" attribute. Created attachment 30746 [details] [review] [SIGNED-OFF] Bug 12744 - Set language in staff client should have 'Cancel' link Test plan Without patch: Click on Library name in head of any staff client page anc choose 'Set library' Result: Form 'Set library' with no 'Cancel' near 'Submit' button With patch: Form displays 'Cancel' link. This link closes the form and takes you back to the page where you came from. New patch without empty "onclick" attribute. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 30876 [details] [review] [PASSED QA] Bug 12744 - Set language in staff client should have 'Cancel' link Test plan Without patch: Click on Library name in head of any staff client page anc choose 'Set library' Result: Form 'Set library' with no 'Cancel' near 'Submit' button With patch: Form displays 'Cancel' link. This link closes the form and takes you back to the page where you came from. New patch without empty "onclick" attribute. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Nice patch, no problems found. Patch pushed to master. Thanks Marc! |