|
Description
Fridolin Somers
2014-08-14 12:32:15 UTC
Created attachment 30786 [details] [review] Bug 12760 - add restrictions purge to cleanup_database.pl This patch adds to the database cleanup script an option to purge expired patron restrictions (debarments in code). Test plan : - Select a borrower - Create a restriction with expiration date in the futur - Create a restriction expired since 7 days - Create a restriction expired since 14 days - run "misc/cronjobs/cleanup_database.pl -v --restrictions 14" => no restriction is removed for this borrower - run "misc/cronjobs/cleanup_database.pl -v --restrictions 13" => restriction expired since 14 days is removed - run "misc/cronjobs/cleanup_database.pl -v --restrictions 6" => restriction expired since 7 days is removed - run without argument "misc/cronjobs/cleanup_database.pl" => You see help text for restrictions option - run without days "misc/cronjobs/cleanup_database.pl -v --restrictions" => You get a purge on 30 days Created attachment 30788 [details] [review] Bug 12760 - add restrictions purge to cleanup_database.pl (followup 1) Remove unused $query var Correct redefined $count var Created attachment 30789 [details] [review] Bug 12760 - add restrictions purge to cleanup_database.pl (followup 2) Formatting : perltidy use q{} for SQL queries add use Modern::Perl Created attachment 30813 [details] [review] Bug 12760 - add restrictions purge to cleanup_database.pl This patch adds to the database cleanup script an option to purge expired patron restrictions (debarments in code). Test plan : - Select a borrower - Create a restriction with expiration date in the futur - Create a restriction expired since 7 days - Create a restriction expired since 14 days - run "misc/cronjobs/cleanup_database.pl -v --restrictions 14" => no restriction is removed for this borrower - run "misc/cronjobs/cleanup_database.pl -v --restrictions 13" => restriction expired since 14 days is removed - run "misc/cronjobs/cleanup_database.pl -v --restrictions 6" => restriction expired since 7 days is removed - run without argument "misc/cronjobs/cleanup_database.pl" => You see help text for restrictions option - run without days "misc/cronjobs/cleanup_database.pl -v --restrictions" => You get a purge on 30 days Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 30814 [details] [review] Bug 12760 - add restrictions purge to cleanup_database.pl (followup 1) Remove unused $query var Correct redefined $count var Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 30815 [details] [review] Bug 12760 - add restrictions purge to cleanup_database.pl (followup 2) Formatting : perltidy use q{} for SQL queries add use Modern::Perl Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 30832 [details] [review] [PASSED QA] Bug 12760 - add restrictions purge to cleanup_database.pl This patch adds to the database cleanup script an option to purge expired patron restrictions (debarments in code). Test plan : - Select a borrower - Create a restriction with expiration date in the futur - Create a restriction expired since 7 days - Create a restriction expired since 14 days - run "misc/cronjobs/cleanup_database.pl -v --restrictions 14" => no restriction is removed for this borrower - run "misc/cronjobs/cleanup_database.pl -v --restrictions 13" => restriction expired since 14 days is removed - run "misc/cronjobs/cleanup_database.pl -v --restrictions 6" => restriction expired since 7 days is removed - run without argument "misc/cronjobs/cleanup_database.pl" => You see help text for restrictions option - run without days "misc/cronjobs/cleanup_database.pl -v --restrictions" => You get a purge on 30 days Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 30833 [details] [review] [PASSED QA] Bug 12760 - add restrictions purge to cleanup_database.pl (followup 1) Remove unused $query var Correct redefined $count var Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 30834 [details] [review] [PASSED QA] Bug 12760 - add restrictions purge to cleanup_database.pl (followup 2) Formatting : perltidy use q{} for SQL queries add use Modern::Perl Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patches pushed to master. Thanks! |