Bug 12781

Summary: DBIx::Class schema should preserve case for column names
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: DatabaseAssignee: Tomás Cohen Arazi (tcohen) <tomascohen>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: major    
Priority: P5 - low CC: gmcharlt, kyle.m.hall, yohann.dufour
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 12784    
Attachments: Bug 12781: update_dbix_class_files.pl should use the preserve_case option
Bug 12781: DBIx::Class schema update 08/2014
Bug 12781: update_dbix_class_files.pl should use the preserve_case option
Bug 12781: DBIx::Class schema update 08/2014
[PASSED QA] Bug 12781: update_dbix_class_files.pl should use the preserve_case option
[PASSED QA] Bug 12781: DBIx::Class schema update 08/2014

Description Tomás Cohen Arazi (tcohen) 2014-08-18 16:08:49 UTC
Our current DBIx::Class::Schema::Loader usage is not preserving case for column names, and thus (the few) column names that contain upper case characters (B_* for borrower attributes, and limitId for branch_transfer_limits) are not accesible using DBIx.

This is easily solved configuration-wise. I'll attach the updated schema in a couple of hours for testing. Once I have regression tests for this.

The problem raised when testing bug 12623.
Comment 1 Tomás Cohen Arazi (tcohen) 2014-08-18 16:15:10 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi (tcohen) 2014-08-18 16:15:13 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2014-08-19 07:25:16 UTC Comment hidden (obsolete)
Comment 4 Chris Cormack 2014-08-19 07:25:29 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-08-20 10:45:59 UTC
Created attachment 31014 [details] [review]
[PASSED QA] Bug 12781: update_dbix_class_files.pl should use the preserve_case option

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Changes make sense, tested by confirming that a patron
modification request for B_<columns> no longer results in
an error message.
Comment 6 Katrin Fischer 2014-08-20 10:46:21 UTC
Created attachment 31018 [details] [review]
[PASSED QA] Bug 12781: DBIx::Class schema update 08/2014

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 7 Tomás Cohen Arazi (tcohen) 2014-08-21 12:58:06 UTC
Patches pushed to master.