|
Description
Marc Véron
2014-08-20 06:30:48 UTC
Created attachment 31006 [details] [review] Bug 12790 - Perl modules: Display required version numbers on about page This patch adds information about required perl module versions to the 'About' page. To test: Apply patch In staff client, go to 'About', tab 'Perl modules' The required version numbers should display in small print underneath the module names. Created attachment 31331 [details] [review] [SIGNED OFF] Bug 12790 - Perl modules: Display required version numbers on about page This patch adds information about required perl module versions to the 'About' page. To test: Apply patch In staff client, go to 'About', tab 'Perl modules' The required version numbers should display in small print underneath the module names. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> I might personally like the numbers better next to the installed version but in parentheses or something similar, but this patch does add useful info Hi Marc, The patch applies. But imo the display does not improve with this patch. This may be an arbitrary design issue... But could you display it somewhat differently? Less confusing? BTW Is it really necessary to show the required version if you have an installed version that is equal or higher? Hope that you could find a way to improve the display. I submitted this patch because of Bug 5599 (it says that Perl dependencies are not compared correctly, e.g. 1.3.12 would be greater than 1.3.5). Created attachment 31347 [details] [review] Bug 12790 - Perl modules: Display required version numbers on about page This patch adds information about required perl module versions to the 'About' page. To test: Apply patch In staff client, go to 'About', tab 'Perl modules' The required version numbers should display in small print underneath the module names. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Needs new Sign-off (code changed) Created attachment 31348 [details] [review] Bug 12790 - Perl modules: Display required version numbers on about page This patch adds information about required perl module versions to the 'About' page. To test: Apply patch In staff client, go to 'About', tab 'Perl modules' The required version numbers should display in small print underneath the module names. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Needs new Sign-off (code changed) Created attachment 31359 [details] [review] Bug 12790: QA-follow-up: Mention required version in online Help For those who would not understand the two version numbers and come up with the idea to check the Help page, some text is added. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 31360 [details] [review] Bug 12790 - Perl modules: Display required version numbers on about page This patch adds information about required perl module versions to the 'About' page. To test: Apply patch. In staff client, go to 'About', tab 'Perl modules' The required version numbers should display in small print next to or underneath the module names. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 31361 [details] [review] Bug 12790: QA-follow-up: Mention required version in online Help For those who would not understand the two version numbers and come up with the idea to check the Help page, some text is added. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> QA Comment: Since the code change is minimal, the signoff of Nick still holds. I saw the About page on a wider screen now, and it looks good. If you make the window smaller, it still does not look nice. Looking at the template code (not your added lines only), it seems that this could be simplified. For instance, a check on the module name does not really make sense. If there is no module name, there should be no row. Furthermore, the template contains several style attrs which probably should be moved to css. Imo the display still needs improvement for a smaller screen, but I will not block this patch for that reason. Passed QA Patches pushed to master. Thanks Marc! Note: i belive the layout should be made cleaner to read, but am happy someone is taking care of end-users :-D |