| Summary: | Proposed changes to Koha plugins system (.KPZ) structure | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Indranil Das Gupta <indradg> |
| Component: | Tools | Assignee: | Indranil Das Gupta <indradg> |
| Status: | Patch doesn't apply --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | chris, dcook, gmcharlt, indradg, josef.moravec, kyle, magnus, mtompset, robin, viktor.sarge |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | Adds koha-enable-plugins and koha-disable-plugins scripts | ||
|
Description
Indranil Das Gupta
2014-08-21 22:13:24 UTC
1) is exactly how the packages do it now, 2) I don't see the need for this. At the moment you edit koha-conf.xml and set enable_plugins to 1 and that's all that's needed. koha-enable-plugins would just do that, but I feel it's doing such a small thing that it may as well be just the edit. One change I would like is supporting .tar.gz, .zip is such a wrong idea on linux systems. But that's probably its own bug :) (In reply to Robin Sheat from comment #1) > 1) is exactly how the packages do it now, Mea culpa! Got that one clarified at #koha :-) > 2) I don't see the need for this. At the moment you edit koha-conf.xml and > set enable_plugins to 1 and that's all that's needed. koha-enable-plugins > would just do that, but I feel it's doing such a small thing that it may as > well be just the edit. Automation and ease-of-use. With newbie users that I'm training up on Ubuntu/Koha combination, it is easier to have them run a "command" rather than fire up an editor, locate the line and change 0 to 1. FWIW, these are not technically savvy people and I've faced several cases of accidental deletion of other crucial lines / insertion of extraneous characters while making these small changes. These are largely train-and-let-go users whose only tech support is via telephone. The installations typically do not have Internet access. But yes, this is a niche case, and perhaps do not map into regular Koha users. I'm OK with having the script created, that's no problem. If someone writes it, I certainly wouldn't veto it :) But be aware that installing plugins may require some additional commandline stuff too, chmod'ing files etc. Due to them being in a zip file, they can end up installed with the most unsafe permissions possible, and that must be fixed from the command line. Also, some scripts may need to be made executable. I can only provide partial feedback here. An optional command line tool would be a welcome addition. It's practical when you are afraid to to mess the file up, while still making it possible to edit it manually and learn a little more about whats going on under the hood. Created attachment 31112 [details] [review] Adds koha-enable-plugins and koha-disable-plugins scripts Command-line koha-* script to toggle <enable_plugins> definition in site specific koha-conf.xml; also to add plugins listing to existing koha-list command. These files are expected to be used for a .deb package based installation of Koha Test plan: 1) Have a koha-common setup installed 2) Apply the patch and build a package for it. 3) Install it. 4) Verify that /yazgfz/config/enable_plugins is being toggled correctly when koha-enable-plugins and koha-disable-plugins are being called respectively. -idg While I haven't tested it yet, this patch looks like a good approach to me. (In reply to Viktor Sarge from comment #5) > I can only provide partial feedback here. An optional command line tool > would be a welcome addition. It's practical when you are afraid to to mess > the file up, while still making it possible to edit it manually and learn a > little more about whats going on under the hood. This got me thinking about the possibilities of adding a general purpose koha-config script. See bug 12824 for some suggestions/questions. Looks like this has a patch that needs signoff. Changing the status accordingly. The new scripts need to be documented in man pages, similar to the existing scripts. With plack changes and the like, this no longer applies. :( Tinkered with getting it up, but not finished, so marking does not apply until someone rebases or fixes it. :) This also should be one script with parameters --enable and --disable, as it is in other Koha debian commands |