Summary: | Sending a list has malformed links | ||
---|---|---|---|
Product: | Koha | Reporter: | Robin Sheat <robin> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P3 | CC: | fridolin.somers, gmcharlt, tomascohen |
Version: | 3.14 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 12849 - fix URLs in sent lists
[SIGNED OFF] Bug 12849 - fix URLs in sent lists [PASSED QA] Bug 12849 - fix URLs in sent lists |
Description
Robin Sheat
2014-08-29 04:18:48 UTC
Created attachment 31272 [details] [review] Bug 12849 - fix URLs in sent lists This brings back the http(s) to the URLs in sent lists. Test plan: * make a list * send it to yourself * see that the URLs aren't clickable * apply the patch * repeat, except now the URLs are better Created attachment 31328 [details] [review] [SIGNED OFF] Bug 12849 - fix URLs in sent lists This brings back the http(s) to the URLs in sent lists. Test plan: * make a list * send it to yourself * see that the URLs aren't clickable * apply the patch * repeat, except now the URLs are better Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Created attachment 31473 [details] [review] [PASSED QA] Bug 12849 - fix URLs in sent lists This brings back the http(s) to the URLs in sent lists. Test plan: * make a list * send it to yourself * see that the URLs aren't clickable * apply the patch * repeat, except now the URLs are better Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> By removing this bit of code, the code in Auth.pm is used instead. The code there is not perfect, but the solution works and both list and cart use the same code. Passes tests and QA script. Patch pushed to master. Thanks Robin! Pushed to 3.16.x for inclusion in 3.16.5. Pushed to 3.14.x, will be in 3.14.13 |