Summary: | Scripts that support logging should enable logging by default | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Packaging | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | robin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12902 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 14167 | ||
Bug Blocks: |
Description
Martin Renvoize (ashimema)
2014-09-01 10:58:51 UTC
Hm, I think I disagree and the logging had been turned off by intention. I think we shouldn't put files with patron sensitive information on the server by default, when the library might not be aware of it. It should be opt in... not opt out. Hm, also there is logging on the database side if you have FinesLog activated. Logging should be set up like most things do it: errors, warnings, info, debug levels. My suggestion is that default, errors (and warnings?) are logged, however are checked to ensure that they won't divulge sensitive information, but is able to give you a heads-up to say that something might need checking out. Also, they should use something like Log::Any or Log4Perl to do it properly, none of this spamming syserr/sysout like some scripts do. Hi Robin, makes sense to me. I wonder if this should be rephrased and what would be a next step here? |