Summary: | Search fails with errors when HTML5 Media is enabled and url has plus (+) characters | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Searching | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, liz, mirko, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12885: Fix if url contains +*... and HTML5 Media is enabled
Bug 12885: Fix if url contains +*... and HTML5 Media is enabled Bug 12885: Fix if url contains +*... and HTML5 Media is enabled [PASSED QA] Bug 12885: Fix if url contains +*... and HTML5 Media is enabled |
Description
Kyle M Hall (khall)
2014-09-08 12:53:02 UTC
Created attachment 41009 [details] [review] Bug 12885: Fix if url contains +*... and HTML5 Media is enabled The special regex chars are not escaped in C4::HTML5Media. Test plan: 1/ Set 856$u=http://www.mrqe.com/lookup?talented+mr.+ripley 2/ Enable the pref HTML5Media 3/ Go on the detail page It should not explode. Created attachment 41210 [details] [review] Bug 12885: Fix if url contains +*... and HTML5 Media is enabled The special regex chars are not escaped in C4::HTML5Media. Test plan: 1/ Set 856$u=http://www.mrqe.com/lookup?talented+mr.+ripley 2/ Enable the pref HTML5Media 3/ Go on the detail page It should not explode. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Created attachment 41523 [details] [review] Bug 12885: Fix if url contains +*... and HTML5 Media is enabled Error disappears and code looks good to me. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Created attachment 42182 [details] [review] [PASSED QA] Bug 12885: Fix if url contains +*... and HTML5 Media is enabled The special regex chars are not escaped in C4::HTML5Media. Test plan: 1/ Set 856$u=http://www.mrqe.com/lookup?talented+mr.+ripley 2/ Enable the pref HTML5Media 3/ Go on the detail page It should not explode. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! Pushed to 3.20.x will be in 3.20.4 Pushed to 3.18.x will be in 3.18.11. |