Summary: | shelfbrowser script should write headers | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12886: shelfbrowser script should write headers
Bug 12886: shelfbrowser script should write headers Bug 12886: shelfbrowser script should write headers [PASSED QA] Bug 12886: shelfbrowser script should write headers |
Description
Jonathan Druart
2014-09-08 14:18:11 UTC
Created attachment 31462 [details] [review] Bug 12886: shelfbrowser script should write headers opac/svc/shelfbrowser.pl does not write http headers. On a production server, this patch resolves a server internal error (500): Bad header= <div id="shelfbrowser"> I did not reproduce on my local instance, but this should be fixed. Test plan: Verify there is no regression on browsing a shelf (with "en" and translated templates) Created attachment 32351 [details] [review] Bug 12886: shelfbrowser script should write headers opac/svc/shelfbrowser.pl does not write http headers. On a production server, this patch resolves a server internal error (500): Bad header= <div id="shelfbrowser"> I did not reproduce on my local instance, but this should be fixed. Test plan: Verify there is no regression on browsing a shelf (with "en" and translated templates) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I am not sure why this happens, but with the patch applied for every time I use the 'arrow' picture, a 1 appears in the bottom left corner. This doesn't happen without the patch applied. Created attachment 33142 [details] [review] Bug 12886: shelfbrowser script should write headers opac/svc/shelfbrowser.pl does not write http headers. On a production server, this patch resolves a server internal error (500): Bad header= <div id="shelfbrowser"> I did not reproduce on my local instance, but this should be fixed. Test plan: Verify there is no regression on browsing a shelf (with "en" and translated templates) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> (In reply to Katrin Fischer from comment #3) > I am not sure why this happens, but with the patch applied for every time I > use the 'arrow' picture, a 1 appears in the bottom left corner. > This doesn't happen without the patch applied. Silly error, print should have been removed, done. Created attachment 33178 [details] [review] [PASSED QA] Bug 12886: shelfbrowser script should write headers opac/svc/shelfbrowser.pl does not write http headers. On a production server, this patch resolves a server internal error (500): Bad header= <div id="shelfbrowser"> I did not reproduce on my local instance, but this should be fixed. Test plan: Verify there is no regression on browsing a shelf (with "en" and translated templates) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, no regressions found. Patch pushed to master. Thanks Jonathan! |