| Summary: | Error in test case causes test failure | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Robin Sheat <robin> |
| Component: | Test Suite | Assignee: | Robin Sheat <robin> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | normal | ||
| Priority: | P4 | CC: | mtompset, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 12716 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 12918 - fix failing test case
Bug 12918 - fix failing test case Bug 12918 - fix failing test case [SIGNED-OFF] Bug 12918: fix failing test case [PASSED QA] Bug 12918: fix failing test case |
||
|
Description
Robin Sheat
2014-09-15 02:07:33 UTC
Created attachment 31588 [details] [review] Bug 12918 - fix failing test case A bug in a test case causes test case failure. Test plan: * Run the test cases. * Note that they work. Created attachment 31592 [details] [review] Bug 12918 - fix failing test case A bug in a test case causes test case failure. It also required a database, so I'm moving it out of the way. Test plan: * Run the test cases. * Note that they work. Created attachment 31602 [details] [review] Bug 12918 - fix failing test case A bug in a test case causes test case failure. It also required a database, so I'm moving it out of the way. Test plan: 1) prove -v t/db_dependent/Templates.t -- bombs! 2) apply patch 3) prove -v t/db_dependent/Templates.t -- works! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 31606 [details] [review] [SIGNED-OFF] Bug 12918: fix failing test case A bug in a test case causes test case failure. It also required a database, so I'm moving it out of the way. Test plan: 1) prove -v t/db_dependent/Templates.t -- bombs! 2) apply patch 3) prove -v t/db_dependent/Templates.t -- works! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Good catch Robin, it didn't fail in Perl 5.18 so didn't notice the mistake. Created attachment 31609 [details] [review] [PASSED QA] Bug 12918: fix failing test case A bug in a test case causes test case failure. It also required a database, so I'm moving it out of the way. Test plan: 1) prove -v t/db_dependent/Templates.t -- bombs! 2) apply patch 3) prove -v t/db_dependent/Templates.t -- works! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Good catch Robin, it didn't fail in Perl 5.18 so didn't notice the mistake. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> BTW, it fails in 5.14 which is Ubuntu 12.04 LTS default. ;) Patch pushed to master. Thanks Robin! |