Bug 12951

Summary: Login failure shows wrong message if user doesn't have the right permissions (staff client)
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: Staff interfaceAssignee: Tomás Cohen Arazi (tcohen) <tomascohen>
Status: CLOSED WORKSFORME QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: abl, gmcharlt, uselibrary27
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Correct failure message
Wrong error message

Description Tomás Cohen Arazi (tcohen) 2014-09-17 23:20:53 UTC
If you try to login with an unprivileged user AND put the wrong password, the attached message shows, and it shouldn't.
Comment 1 Tomás Cohen Arazi (tcohen) 2014-09-17 23:22:27 UTC
Created attachment 31688 [details]
Correct failure message
Comment 2 Tomás Cohen Arazi (tcohen) 2014-09-17 23:22:55 UTC
Created attachment 31689 [details]
Wrong error message
Comment 3 Tomás Cohen Arazi (tcohen) 2014-09-17 23:25:28 UTC
Well, the "correct" one is not correct, indeed. It should be the same page, but without the buttons.
Comment 4 Jacek Ablewicz 2014-09-18 10:05:40 UTC
I'm far from sure Bug 12951 and Bug 12954 are actually related in any way.. but that part

   AND put the wrong password

got me thinking; judging from the (somehow similar) symptoms, it looks like there is a possibility that both bugs may have the same underlying cause (?).
Comment 5 Owen Leonard 2016-08-15 18:43:50 UTC
I can't reproduce this problem in master. Is it still valid?
Comment 6 Katrin Fischer 2020-01-06 10:58:06 UTC
(In reply to Owen Leonard from comment #5)
> I can't reproduce this problem in master. Is it still valid?

Same for me - it shows the correct message:
Error: Invalid username or password