| Summary: | Price formatting should only be defined at one place | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | paola.rossi, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 12844 | ||
| Bug Blocks: | 4078, 13352 | ||
| Attachments: |
Bug 12979: Price formatting should only be defined at one place
Bug 12979: Fix error on layout3pagesfr Bug 12979: Price formatting should only be defined at one place Bug 12979: Fix error on layout3pagesfr [PASSED QA] Bug 12979: Price formatting should only be defined at one place [PASSED QA] Bug 12979: Fix error on layout3pagesfr |
||
|
Description
Jonathan Druart
2014-09-23 10:01:47 UTC
Created attachment 31829 [details] [review] Bug 12979: Price formatting should only be defined at one place There are some places where the price format is defined. All these occurrences should be removed use the way introduced by bug 12844. Test plan: 1/ Verify you don't see any price formatting change on the basketgroup pdf (for layout2pages, payout2pagesde, layout3pages and layout3pagesfr). 2/ On admin/aqbudgetperiods.pl, the budget total should be unchanged too. I've applied the patch against 3.17.00.025 On the 3-rd page FR, I saw: Prix Koha::Number::Price=HASH(0x743ecd8) Prix net: Koha::Number::Price=HASH(0x743ed08) %Remise: Koha::Number::Price=HASH(0x743ed68)% Remise: Koha::Number::Price=HASH(0x743edb0) So I pass the patch to "Failed QA" status. Created attachment 31936 [details] [review] Bug 12979: Fix error on layout3pagesfr The format method was not called. Good catch Paola! Stupid error, it is fixed in the last patch. Created attachment 31946 [details] [review] Bug 12979: Price formatting should only be defined at one place I've applied against 3.17.00.025 >>git grep Number::Format 1) C4/Installer/PerlDependencies.pm: 'Number::Format' => { 2) Koha/Number/Price.pm:use Number::Format qw( format_price ); 3) Koha/Number/Price.pm: return Number::Format->new(%$format_params)->format_price($self->value); 4) Koha/Number/Price.pm: return Number::Format->new(%$format_params)->unformat_number($self->value); 5) t/Number/Price.t:# How put the symbol at the end with Number::Format? Everything is OK. I pass the patch to "Signed Off" status. Created attachment 31947 [details] [review] Bug 12979: Fix error on layout3pagesfr Created attachment 32574 [details] [review] [PASSED QA] Bug 12979: Price formatting should only be defined at one place There are some places where the price format is defined. All these occurrences should be removed use the way introduced by bug 12844. Test plan: 1/ Verify you don't see any price formatting change on the basketgroup pdf (for layout2pages, payout2pagesde, layout3pages and layout3pagesfr). 2/ On admin/aqbudgetperiods.pl, the budget total should be unchanged too. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 32575 [details] [review] [PASSED QA] Bug 12979: Fix error on layout3pagesfr The format method was not called. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> No regressions found, passes tests and QA script. Patches pushed to master. Thanks Jonathan! |