Bug 12980

Summary: GetHistory does useless processing
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: chris, paola.rossi, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 12826    
Attachments: Bug 12980: GetHistory does useless processing
Bug 12980: GetHistory does useless processing
[PASSED QA] Bug 12980: GetHistory does useless processing

Description Jonathan Druart 2014-09-23 11:04:51 UTC
GetHistory iterated on the orders to calculate the quantity and price.
These values are never used by the called.
It can be removed.
Comment 1 Jonathan Druart 2014-09-23 11:10:03 UTC Comment hidden (obsolete)
Comment 2 Paola Rossi 2014-09-26 14:51:57 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-10-03 13:55:41 UTC
Created attachment 31984 [details] [review]
[PASSED QA] Bug 12980: GetHistory does useless processing

GetHistory iterated on the orders to calculate the quantity and price.
These values are never used by the called.
It can be removed.

Test plan:
Verify there is no regression on acqui/histsearch.pl and
catalogue/detail.pl
Actually you just have to check that the total quantity and price are
not displayed on these views.

QA: note that 'count' and 'toggle' are never used in the template.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2014-12-03 14:54:07 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 5 Chris Cormack 2014-12-03 20:03:16 UTC
Pushed to 3.18.x will be in 3.18.01