Summary: | Untranslatable string on enhanced_content.pref | ||
---|---|---|---|
Product: | Koha | Reporter: | Bernardo Gonzalez Kriegel <bgkriegel> |
Component: | I18N/L10N | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bouzid.fergani, f.demians, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 12999: Untranslatable string on enhanced_content.pref
Bug 12999: Untranslatable string on enhanced_content.pref [SIGNED-OFF] Bug 12999: Untranslatable string on enhanced_content.pref Bug 12999: Untranslatable string on enhanced_content.pref Bug 11299 small fix because TransformHtmlToMarc parameters it's changed |
Description
Bernardo Gonzalez Kriegel
2014-09-26 00:33:31 UTC
Created attachment 31885 [details] [review] Bug 12999: Untranslatable string on enhanced_content.pref This patch modifies LangInstaller.pm to catch strings on syspref files that have no associated syspref To test: 1) Update strings for your preffered language 2) Check that the string "you can only choose one source" is not present on xx-YY-pref.po file 3) Apply the patch 4) Update strings again 5) Check the strig now appears [ and another one :) ] Doing a diff before and after will show > # Enhanced Content > All > msgid "enhanced_content.pref## <strong>NOTE:</strong> you can only choose one source of cover images from below, otherwise Koha will show the images from all sources selected." > msgstr "" > 3013a3018,3021 > > # Local Use > msgid "local_use.pref## Nothing defined yet." > msgstr "" 6) Translate the string 7) Install your language, check Administration > System preferences > Enhanced content > All (on your languge) and check the string is now translated Created attachment 31886 [details] [review] Bug 12999: Untranslatable string on enhanced_content.pref This patch modifies LangInstaller.pm to catch strings on syspref files that have no associated syspref To test: 1) Update strings for your preffered language 2) Check that the string "you can only choose one source" is not present on xx-YY-pref.po file 3) Apply the patch 4) Update strings again 5) Check the strig now appears [ and another one :) ] Doing a diff before and after will show # Enhanced Content > All msgid "enhanced_content.pref## <strong>NOTE:</strong> you can only choose one source of cover images from below, otherwise Koha will show the images from all sources selected." msgstr "" # Local Use msgid "local_use.pref## Nothing defined yet." msgstr "" 6) Translate the string 7) Install your language, check Administration > System preferences > Enhanced content > All (on your languge) and check the string is now translated Created attachment 32144 [details] [review] [SIGNED-OFF] Bug 12999: Untranslatable string on enhanced_content.pref This patch modifies LangInstaller.pm to catch strings on syspref files that have no associated syspref To test: 1) Update strings for your preffered language 2) Check that the string "you can only choose one source" is not present on xx-YY-pref.po file 3) Apply the patch 4) Update strings again 5) Check the strig now appears [ and another one :) ] Doing a diff before and after will show # Enhanced Content > All msgid "enhanced_content.pref## <strong>NOTE:</strong> you can only choose one source of cover images from below, otherwise Koha will show the images from all sources selected." msgstr "" # Local Use msgid "local_use.pref## Nothing defined yet." msgstr "" 6) Translate the string 7) Install your language, check Administration > System preferences > Enhanced content > All (on your languge) and check the string is now translated Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 32259 [details] [review] Bug 12999: Untranslatable string on enhanced_content.pref This patch modifies LangInstaller.pm to catch strings on syspref files that have no associated syspref To test: 1) Update strings for your preffered language 2) Check that the string "you can only choose one source" is not present on xx-YY-pref.po file 3) Apply the patch 4) Update strings again 5) Check the strig now appears [ and another one :) ] Doing a diff before and after will show # Enhanced Content > All msgid "enhanced_content.pref## <strong>NOTE:</strong> you can only choose one source of cover images from below, otherwise Koha will show the images from all sources selected." msgstr "" # Local Use msgid "local_use.pref## Nothing defined yet." msgstr "" 6) Translate the string 7) Install your language, check Administration > System preferences > Enhanced content > All (on your languge) and check the string is now translated Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I am not sure I can explain this patch, but I confirm the only change in po files are: diff fr-FR-pref.po old/fr-FR-pref.po 2295a2296,2299 > # Enhanced Content > All > msgid "enhanced_content.pref## <strong>NOTE:</strong> you can only choose one source of cover images from below, otherwise Koha will show the images from all sources selected." > msgstr "" > 3014a3019,3022 > > # Local Use > msgid "local_use.pref## Nothing defined yet." > msgstr "" Patch pushed to master. Thanks Bernardo! Created attachment 56441 [details] [review] Bug 11299 small fix because TransformHtmlToMarc parameters it's changed sorry, it's error |